Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing sys reg handling #228

Merged
merged 2 commits into from
May 12, 2022
Merged

Missing sys reg handling #228

merged 2 commits into from
May 12, 2022

Conversation

jj16791
Copy link
Contributor

@jj16791 jj16791 commented May 12, 2022

This PR contains a fix for handling missing system registers in the aarch64 systemRegisterMap_ map. A missing entry will return a -1 and a decoded instruction accessing an unmapped system register will raise a new UnmappedSysReg fatal exception.

@jj16791 jj16791 added the enhancement New feature or request label May 12, 2022
@jj16791 jj16791 requested a review from FinnWilkinson May 12, 2022 10:38
Copy link
Contributor

@FinnWilkinson FinnWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

@jj16791
Copy link
Contributor Author

jj16791 commented May 12, 2022

#rerun tests

@jj16791 jj16791 merged commit 75ccc4f into dev May 12, 2022
tomhepworth pushed a commit that referenced this pull request Jun 25, 2022
A fix for handling missing system registers in the aarch64 systemRegisterMap_ map. A missing entry will return a -1 and a decoded instruction accessing an unmapped system register will raise a new UnmappedSysReg fatal exception.
jj16791 added a commit that referenced this pull request Jul 28, 2022
A fix for handling missing system registers in the aarch64 systemRegisterMap_ map. A missing entry will return a -1 and a decoded instruction accessing an unmapped system register will raise a new UnmappedSysReg fatal exception.
jj16791 added a commit that referenced this pull request Aug 1, 2022
A fix for handling missing system registers in the aarch64 systemRegisterMap_ map. A missing entry will return a -1 and a decoded instruction accessing an unmapped system register will raise a new UnmappedSysReg fatal exception.
tomhepworth pushed a commit that referenced this pull request Aug 13, 2022
A fix for handling missing system registers in the aarch64 systemRegisterMap_ map. A missing entry will return a -1 and a decoded instruction accessing an unmapped system register will raise a new UnmappedSysReg fatal exception.
jj16791 added a commit that referenced this pull request Sep 13, 2022
A fix for handling missing system registers in the aarch64 systemRegisterMap_ map. A missing entry will return a -1 and a decoded instruction accessing an unmapped system register will raise a new UnmappedSysReg fatal exception.
jj16791 added a commit that referenced this pull request Oct 17, 2022
A fix for handling missing system registers in the aarch64 systemRegisterMap_ map. A missing entry will return a -1 and a decoded instruction accessing an unmapped system register will raise a new UnmappedSysReg fatal exception.
@jj16791 jj16791 deleted the missing-sys-reg-handling branch October 18, 2022 15:06
jj16791 added a commit that referenced this pull request Oct 21, 2022
A fix for handling missing system registers in the aarch64 systemRegisterMap_ map. A missing entry will return a -1 and a decoded instruction accessing an unmapped system register will raise a new UnmappedSysReg fatal exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants