Improve iOS 10.3 review dialog support + documentation #112
Conversation
Source/Armchair.swift
Outdated
| @@ -1703,23 +1737,19 @@ open class Manager : ArmchairManager { | |||
| #endif | |||
|
|
|||
| private func hideRatingAlert() { | |||
| #if os(OSX) | |||
There was a problem hiding this comment.
Why was all this edited? It still needs to be split by iOS and OSX to properly handle Mac App implementations.
There was a problem hiding this comment.
@coneybeare Good catch, I'll correct that.
MartinMoizard
force-pushed
the
master
branch
from
cb0bfd5 to
b3bd6ec
Compare
There was a problem hiding this comment.
Thanks for the review @coneybeare , I took into account your feedback. Let me know if it looks good for you now.
Source/Armchair.swift
Outdated
| @@ -1703,23 +1737,19 @@ open class Manager : ArmchairManager { | |||
| #endif | |||
|
|
|||
| private func hideRatingAlert() { | |||
| #if os(OSX) | |||
There was a problem hiding this comment.
@coneybeare Good catch, I'll correct that.
|
Alright, looks good, thanks! |
|
Just checked and you don't compile for Mac! please fix so that the Mac Example App compiles and works. Remember that SKStoreReviewController and store kit reviewing is not available for Mac, so all that logic needs to be contained in a compile-time |
|
@MartinMoizard 👋 can you look into macOS demo issues? |
Hello,
This is a fork of #102 + I added the requested documentation.
I went ahead and did that because it only missed the documentation, and I think we can all benefit from this nice change.
@coneybeare let me know if I should change anything more.
Thanks