Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NXTG-976] Add Mint Error retries #5

Merged
merged 3 commits into from
Apr 13, 2023
Merged

[NXTG-976] Add Mint Error retries #5

merged 3 commits into from
Apr 13, 2023

Conversation

Abdallahj94
Copy link
Collaborator

@Abdallahj94 Abdallahj94 commented Apr 13, 2023

Description

Add retry mechanism for random TCP socket closed errors in Mint
sneako/finch#62

Fixes: NXTG-976

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance boost or paying a technical debit 💰 (non-breaking change).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested (Self-tested).
  • With the help of our Quality Assurance people.
  • Added automated tests for it 🥇.

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have checked my code and corrected any misspellings.

@Abdallahj94 Abdallahj94 merged commit fe9eb94 into main Apr 13, 2023
@Abdallahj94 Abdallahj94 deleted the mint-reties branch April 13, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants