Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current vite peerDep prevents from using the plugin with vite 4 #24

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

abernier
Copy link
Contributor

@abernier abernier commented Dec 10, 2022

since few days, vite 4 is out. Projects using vite@4, and vite-plugin-gsl will encounter this peerDep issue:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/vite
npm ERR!   dev vite@"^4.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer vite@"^3.0.0" from [email protected]
npm ERR! node_modules/vite-plugin-glsl
npm ERR!   dev vite-plugin-glsl@"^0.5.4" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/vite
npm ERR!   peer vite@"^3.0.0" from [email protected]
npm ERR!   node_modules/vite-plugin-glsl
npm ERR!     dev vite-plugin-glsl@"^0.5.4" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/runner/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2022-12-10T10_35_09_491Z-debug-0.log
Error: Process completed with exit code 1.

NB: FYI I tried using vite-plugin-glsl on a vite 4 project (--forceing the warning and has no issue with)...

since few days, vite 4 is out. Projects using `vite@4`, and `vite-plugin-gsl` will encounter this peerDep issue:

```
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/vite
npm ERR!   dev vite@"^4.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer vite@"^3.0.0" from [email protected]
npm ERR! node_modules/vite-plugin-glsl
npm ERR!   dev vite-plugin-glsl@"^0.5.4" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/vite
npm ERR!   peer vite@"^3.0.0" from [email protected]
npm ERR!   node_modules/vite-plugin-glsl
npm ERR!     dev vite-plugin-glsl@"^0.5.4" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/runner/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2022-12-10T10_35_09_491Z-debug-0.log
Error: Process completed with exit code 1.
```
@abernier
Copy link
Contributor Author

steps to reproduce:

$ npm create vite@latest
$ cd vite-project
$ npm i

$ npm i vite-plugin-glsl

@abernier abernier changed the title chore: vite 4 is out current vite peerDep prevents from using the plugin with vite 4 Dec 10, 2022
@UstymUkhman UstymUkhman merged commit ac0c887 into UstymUkhman:main Dec 11, 2022
@UstymUkhman
Copy link
Owner

Hi @abernier, thank you so much for your contribution! ❤
I'll publish a new version on NPM with this support for vite^4.0 asap.
Please consider smashing a ⭐if you've found this plugin useful to your purposes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants