Repair team #269

AndrewBelt · 2018-02-14T16:34:54Z

The Repair team is the first VCV Community team to launch. The goal is simple: For each open-source plugin in the Plugin Manager, help the developer by sending a pull request that makes it build against the latest master branch of Rack. If you are not quite familiar with GitHub and git, the procedure is the following.

Make sure to git checkout master and git pull the latest Rack source code, and build it.
Pick your favorite plugin and click Fork on its GitHub page.
git clone the forked repo in your plugins/ folder.
Inspect the code, and apply the changes mentioned in the Plugin API Updates Thread
Update the form of the Makefile to follow the Template Makefile, including the RACK_DIR which will be useful later.
Try building it with make -j$(nproc). If you changed everything correctly and it finally builds, make a commit with a message like "Updated to Rack 0.6 API", and git push.
On your GitHub fork, click "Create Pull Request", and submit it back to the plugin developer.
After the plugin developer accepts your pull request, you may delete your personal repository.

The text was updated successfully, but these errors were encountered:

cschol · 2018-02-15T02:37:25Z

dhemery · 2018-02-15T02:42:29Z

I develop DHE-Modules, and have completed the conversion myself.

cschol · 2018-02-15T02:55:34Z

@phdsg Oops. That was an artifact of how I generated the list. Removed. Thanks.

AndrewBelt · 2018-02-15T02:59:18Z

Looks great, I'm working on mine.
People can't check your own checkmarks, they'll just have to post here.

cschol · 2018-02-15T03:00:14Z

@AndrewBelt Crap, I was hoping they could. I'll keep the list up to date from people posting here below. Updated the instructions above to have people post the name of the module they are working on.

wizardishungry · 2018-02-15T03:27:40Z

PulsumQuadratum-rtlsdr: I'm doing it myself. (It also needs to have its dependencies built as git submodules before it will build without special instructions)

Strum · 2018-02-15T05:15:12Z

@cschol

I'll do mine myself, and can help with others if you need it.

cschol · 2018-02-15T13:51:44Z

@Strum Thank you. Which ones are your's again?

AndrewBelt · 2018-02-15T17:20:07Z

Added one additional instruction to make sure that your Makefiles are up-to-date and follow the Template Makefile or the Fundamental Makefile.

Strum · 2018-02-16T04:42:00Z

@phdsg thanks.

luckyxxl · 2018-02-18T08:50:54Z

@cschol fixed mine just now

mdemanett · 2018-02-18T18:59:18Z

Bogaudio is up to date. Cheers.

djpeterso23662 · 2018-02-18T21:27:48Z

I will take care of MrLumps. Thanks!

alikins · 2018-02-19T03:35:30Z

I have converted my plugin ('Alikins') to the 0.6 API in it's master branch.

alikins · 2018-02-19T05:41:15Z

Pr for mtsch at mtsch/mtsch-vcvrack-plugins#5

dllmusic · 2018-02-19T08:06:50Z

I will update moDllz... just waiting to see how the MIDI is implemented

cfoulc · 2018-02-19T09:17:05Z

cf - working on mine, may need some help at some point, will ask here and/or there
EDIT : done, everything working fine and uploaded to my repo :)

gbrandt1 · 2018-02-19T12:29:58Z

i'll work on mine (Southpole) - the update will depend somewhat on the various MI / Parasites repos i copied from

jhoar · 2018-02-19T12:41:08Z

I've done AmalgamatedHarmonics.

cschol · 2018-02-19T14:49:09Z

Thank you for the PR @alikins!

AScustomWorks · 2018-02-19T18:23:16Z

I'll work on mine

antoniograzioli · 2018-02-20T08:37:38Z

I am updating my plugins, started a couple of days ago, I will (hopefully) finish them tonight. Bear with me I am quite busy and there are quite a lot of changes to be done ;-) also, my https://github.com/antoniograzioli/Autodafe repository is a complete mess, and needs to be erased completely...

Strum · 2018-02-20T13:31:31Z

ok mental modules are done, the new code is on the 06dev branch.

wizardishungry · 2018-02-20T14:59:41Z

Is AudibleInstruments building for people? I.e. should it be unchecked?

ValleyAudio · 2018-03-28T17:42:29Z

@cschol Was the submodule for Valley updated? Apparently my commits on branch v0.6 are ahead of the submodule

AndrewBelt · 2018-03-28T17:52:11Z

Starting now, all plugin developers need to follow the instructions at https://github.com/VCVRack/community#for-plugin-developers-addingupdating-your-plugin to update your plugins from the state in the Plugin Manager. PRs will no longer be accepted from anyone except team members, and this issue is now limited to only Repair Team members.

cschol · 2018-03-28T18:23:47Z

~~@AndrewBelt This might have been accidentally closed without merging: I opened #369 and updated some of the plugins (including @ValleyAudio) to the latest repo revisions.~~

Never mind. I understand now why this was done. I will create new PR(s).

cschol · 2018-04-03T03:32:13Z

Sorry, I have been out of town for a few days. Plugin list has been updated.

@phdsg qwelk and LFSR should be ready for integration into the community repository.

AndrewBelt · 2018-04-03T04:07:01Z

@cschol Welcome back!

The-XOR · 2018-04-03T09:42:28Z

makefile versioned 0.6.1

phdsg · 2018-04-23T18:34:37Z

IO-simple has merged changes for 0.6 compatibility.
i haven't had the time to try it yet.
if this builds on all 3 platforms we can cross another one from the list and update the manifest and submodule.
:)
@cschol still here?

cschol · 2018-04-24T04:34:23Z

@phdsg Yeah, sorry, work/life gets in the way right now. :) I updated the list and crossed off IO-simple.

cschol · 2018-04-28T13:40:06Z

@phdsg Is Nohmad just waiting for a build or is there anything else wrong with the plugin?

phdsg · 2018-04-28T14:18:29Z

it's not added as a submodule because it wasn't ready during the transition and the dev hasn't opened an issue here yet. there are a few more of those cases. i'll spend a few moments in the next days to invite them to open their channel here if they want to be added to the plugin manager.

cschol · 2018-04-28T17:28:10Z

Ah, I see. Sorry, been trying to catch up here. Thanks.

JeffGreenlee42 · 2019-01-05T06:54:26Z

Hello! Andrew... you suggested I post to this thread (to offer assistance on lowering the 20+ manhours.... ?) 👍 . Looks like this thread is a little errrr. musty with age? Last posting was for yikes! May of last year? I'm not sure what exactly a "bounty" consists of..... but How might I be of assistance?

cschol · 2019-01-12T02:21:15Z

@JeffGreenlee42 Well, there hasn't been much to repair so therefore there is no activity here. I am still a little confused as to what you are exactly looking for. Can you elaborate? Thanks.

@AndrewBelt I read the thread on Facebook, but I am confused what the time would be used for. Update manifests to the new plugin.json format?

AndrewBelt · 2019-01-12T02:24:22Z

@JeffGreenlee42 Oh yes, I forgot to respond to this. Didn't you mention on Facebook that you wanted to offer a financial bounty (or perhaps encourage other people to do so) for the Repair Team's time here?
But yes, it's dead here because all interesting plugins we know of have been ported to 0.6, so we're just waiting on the Rack v1 API to become stable to begin helping AWOL developers to upgrade their code.

JeffGreenlee42 · 2019-01-12T04:40:59Z

Oh... My apologies,. I was not offering financial support.... ( I am dry as a turnip) but I read in the thread that you might need "manhour" support..... Just folks who might be able to do tasks to lower the burden. I am a software tester..and errrr.. well it takes a village.. . So maybe some of us could help? Jeff

…

On Fri, Jan 11, 2019 at 6:24 PM Andrew Belt ***@***.***> wrote: @JeffGreenlee42 <https://github.com/JeffGreenlee42> Oh yes, I forgot to respond to this. Didn't you mention on Facebook that you wanted to offer a financial bounty (or perhaps encourage other people to do so) for the Repair Team's time here? But yes, it's dead here because all interesting plugins we know of have been ported to 0.6, so we're just waiting on the Rack v1 API to become stable to begin helping AWOL developers to upgrade their code. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#269 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVifXaHeDKDXazzeKVpUAXAojfM6pBXkks5vCUdYgaJpZM4SFm1L> .

AndrewBelt · 2019-01-12T04:58:59Z

Oh yes, you can certainly join. Just subscribe to this thread and wait for new information when the Rack v1 API is stable.

catronomix · 2019-06-20T23:00:52Z

I seem to be the first to revive this thread :)
Got a problem trying to transfer my modules to v1... I'm stuck at 1.9 from the migration manual, rack keeps crashing when I open the module browser.
I made an issue: catronomix/catro-modulo#11

AndrewBelt · 2019-06-21T01:55:29Z

@catronomix That had happened to me before for unknown reasons. The solution was to simply proceed with phase 2, and it will magically fix itself.
I believe the problem had to do with the order of constructors with the deprecated wrappers in rack0.hpp.

JerrySievert · 2019-06-21T02:01:48Z

@AndrewBelt in this case, it's a little different:

float *value;

if (module) {
  value = &module->value;
} else {
  value = 3.14159;
}

but specifics being a custom component.

JerrySievert · 2019-06-21T02:03:43Z

but yes, I ran into the deprecated wrappers issue, and pressing on fixed those issues.

catronomix · 2019-06-21T16:24:59Z

@JerrySievert I moved the initialization of recball_x and recball_y to the constructor of recball like this:
in the module cpp:

//selector indicator yellow
		CM3_RecBall *recball = new CM3_RecBall();
		recball->box.size = Vec(32.0, 32.0);
		if (module){
		recball->recball_x = &module->recball_x;
		recball->recball_y = &module->recball_y;
		}
		addChild(recball);

and in the plugin hpp:

float *recball_x;
	float *recball_y;

	CM3_RecBall() {
		recball_x = new float(178.1);
		recball_y = new float(89.5);
	};

Which didn't fix the crash. Then I followed @AndrewBelt 's advice and proceeded with the conversion as per the manual. It all builds fine but the crash still happens.

I'm on Windows 10, using VSCode and then mingw/gcc to compile with make dist and then I copy the plugin to the rack plugin directory to test if it works. But Rack always crashes without showing any error. log.txt also never showed me any errors ever :/

I would like to debug my plugins to see where things go wrong, but I dont find a tutorial on how to debug.Only bits of info in issues like these https://github.com/VCVRack/Rack/issues/172 but I can't make heads or tails of it.

JerrySievert · 2019-06-21T16:28:35Z

@catronomix I'll open a PR on your module in your repo, and continue the conversation there.

almostEric · 2019-06-21T16:28:53Z

If you look on the developer FB group, I posted asking about debuggers. There was quite a bit of response that should help you (I’m using VSCode too)

squinkylabs · 2019-06-22T05:34:37Z

yep lots of info. the super basic is:

make debug (launches rack with the debugger attached)
run (start the debugger exectuing rack)
(do stuff until it crashes. you will be back at the debugger prompt)
bt (dumps the stack leading up to the crash)

look at the screen and figure out what happened. Or google "gdb cheat sheet"

catronomix · 2019-06-22T10:07:42Z

but how does it know where to find rack? because thats installed in windows, but the plugin gets compiled in my dev folder where the rack sdk is located. I guess I have to compile some debug version of rack inside the dev folder as well?

AndrewBelt · 2023-02-14T00:14:05Z

Closing since the VCV Community forum is a better place for discussing adopting plugin maintenance.

AndrewBelt added the community label Feb 14, 2018

AndrewBelt mentioned this issue Feb 14, 2018

VCV Community invitation #248

Closed

wizardishungry added a commit to bongozone/vcvrack-rtlsdr that referenced this issue Feb 15, 2018

update Makefile again per VCVRack/library#269

5b98a58

This was referenced Feb 20, 2018

Update to Rack API v0.6 mhetrick/hetrickcv#11

Merged

Update to Rack API v0.6 charlie-rbchd/Nohmad#6

Merged

VCVRack deleted a comment from antoniotuzzi Feb 20, 2018

cschol mentioned this issue Mar 26, 2018

Create alto777_LFSR #366

Closed

phdsg mentioned this issue Apr 4, 2018

TheXOR #397

Closed

AndrewBelt mentioned this issue May 3, 2018

Add Wiki page for Contribution Guide #463

Closed

AndrewBelt closed this as completed Feb 14, 2023

Repair team #269

Repair team #269

Comments

AndrewBelt commented Feb 14, 2018 • edited Loading

cschol commented Feb 15, 2018 • edited Loading

dhemery commented Feb 15, 2018

cschol commented Feb 15, 2018

AndrewBelt commented Feb 15, 2018

cschol commented Feb 15, 2018 • edited Loading

wizardishungry commented Feb 15, 2018

Strum commented Feb 15, 2018

cschol commented Feb 15, 2018

AndrewBelt commented Feb 15, 2018

Strum commented Feb 16, 2018

luckyxxl commented Feb 18, 2018

mdemanett commented Feb 18, 2018

djpeterso23662 commented Feb 18, 2018

alikins commented Feb 19, 2018

alikins commented Feb 19, 2018

dllmusic commented Feb 19, 2018

cfoulc commented Feb 19, 2018 • edited Loading

gbrandt1 commented Feb 19, 2018

jhoar commented Feb 19, 2018

cschol commented Feb 19, 2018

AScustomWorks commented Feb 19, 2018

antoniograzioli commented Feb 20, 2018 • edited Loading

Strum commented Feb 20, 2018

wizardishungry commented Feb 20, 2018

ValleyAudio commented Mar 28, 2018

AndrewBelt commented Mar 28, 2018 • edited Loading

cschol commented Mar 28, 2018 • edited Loading

cschol commented Apr 3, 2018

AndrewBelt commented Apr 3, 2018

The-XOR commented Apr 3, 2018

phdsg commented Apr 23, 2018

cschol commented Apr 24, 2018

cschol commented Apr 28, 2018

phdsg commented Apr 28, 2018

cschol commented Apr 28, 2018

JeffGreenlee42 commented Jan 5, 2019

cschol commented Jan 12, 2019 • edited Loading

AndrewBelt commented Jan 12, 2019

JeffGreenlee42 commented Jan 12, 2019 via email

AndrewBelt commented Jan 12, 2019

catronomix commented Jun 20, 2019

AndrewBelt commented Jun 21, 2019

JerrySievert commented Jun 21, 2019

JerrySievert commented Jun 21, 2019

catronomix commented Jun 21, 2019

JerrySievert commented Jun 21, 2019

almostEric commented Jun 21, 2019

squinkylabs commented Jun 22, 2019

catronomix commented Jun 22, 2019

AndrewBelt commented Feb 14, 2023

AndrewBelt commented Feb 14, 2018 •

edited

Loading

cschol commented Feb 15, 2018 •

edited

Loading

cschol commented Feb 15, 2018 •

edited

Loading

cfoulc commented Feb 19, 2018 •

edited

Loading

antoniograzioli commented Feb 20, 2018 •

edited

Loading

AndrewBelt commented Mar 28, 2018 •

edited

Loading

cschol commented Mar 28, 2018 •

edited

Loading

cschol commented Jan 12, 2019 •

edited

Loading