Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create alto777_LFSR #366

Closed
wants to merge 1 commit into from
Closed

Create alto777_LFSR #366

wants to merge 1 commit into from

Conversation

alto777
Copy link

@alto777 alto777 commented Mar 26, 2018

I propose to dare to share my plugin. I'm still not sure I'm where I should be doing.

I propose to dare to share my plugin.
@alto777
Copy link
Author

alto777 commented Mar 26, 2018

Sorry, this doesn't look like it is headed where I thought, community?

@cschol
Copy link
Collaborator

cschol commented Mar 26, 2018

Thanks for submitting your plugin.

There is one minor issue with the plugin itself. It is logged here.

Once you have fixed that issue, we can merge this manifest into the current version of the community repository.

I have added your plugin to the list in the Repair Thread, which tracks migration to the new version of the community repository for version 0.6 of Rack.

Once you have migrated your plugin to the v0.6 of the Rack API, I will add the plugin to the v2 branch of the community repo. Comment in the Repair Thread above if your conversion is done.

Looking forward to trying out your plugin.

@AndrewBelt
Copy link
Member

Also you need a .json extension.

But let's not worry about it, because starting now, we should only accept issues to be handled by the Repair team #269

@alto777
Copy link
Author

alto777 commented Mar 26, 2018

Okay - I intended to build against 0.5.0, since I git cloned Rack and also (I think) "checkout"ed v0.5.

I also thought several odd problems were also fixed by "checkout", in particular two different Template examples.

I'll have a look after breakfast (!) - is there a way to determine which version of Rack I built? I also have regular Rack just from what was my first naive download of the app, it neither seems to divulge its version, nor does OS X "Get Info".

THX.

Oh, while you're here, I see that my LICENSE.txt refers to Andrew Belt, should I just change that to my name? Or add/say something like portions (C) Andrew Bolt (or more accurately tweaks (C) Robert A Moeser)? I have no claims of my own, just want to do the right thing here.

@AndrewBelt
Copy link
Member

is there a way to determine which version of Rack I built?

Check the branch you're on with git branch. If master, then you've built "Rack master", which is the unversioned latest bleeding edge code.
You can also open Rack and look at the title bar for the version.

Your plugin code is your own. If you derived it from the Template plugin, I released that code into the public domain, and I personally believe that using the API of a program is uncopyrightable.

@alto777
Copy link
Author

alto777 commented Mar 26, 2018

OK on license, thanks.

My built Rack is v0.5. I thought doing that would avoid the speeding train problem - easier to work with a non-changing entity.

When I cloned the Template, it failed, natch. That's when I learned about checkout v0.5, which made the first (and all) errors disappear. I got a bad reference to clampf, or something like that and had recalled seeing that it changed from version to version, so…

That means I think that I have been building to v0.5 my plugins. I imagine the thing to do would be to set up a separate Rack dev directory and clone the master? Then see what I need to fix, although so far my plugins do seem to function with the downloaded app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants