Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImpromptuModular #356

Closed
MarcBoule opened this issue Mar 23, 2018 · 93 comments
Closed

ImpromptuModular #356

MarcBoule opened this issue Mar 23, 2018 · 93 comments
Labels

Comments

@MarcBoule
Copy link

MarcBoule commented Mar 23, 2018

I don't know if I should be posting this here, but I would like to supply my manifest file for the v2 community repo, and also request an update of the repo link to my latest master. Thanks!
ImpromptuModular.json:

{
  "name": "ImpromptuModular",
  "author": "Marc Boulé",
  "license": "BSD 3-clause",
  "contactEmail": "[email protected]",
  "websiteUrl": "https://github.com/MarcBoule/ImpromptuModular",
  "manualUrl": "https://github.com/MarcBoule/ImpromptuModular",
  "sourceUrl": "https://github.com/MarcBoule/ImpromptuModular",
  "latestVersion": "0.6.0",
  "status": ""
}
@AndrewBelt AndrewBelt changed the title ImpromptuModular.json and repo update ImpromptuModular Mar 23, 2018
@MarcBoule
Copy link
Author

MarcBoule commented Mar 23, 2018

Thanks Andrew. For the readme url, I was indeed thinking of supplying this link instead:
https://github.com/MarcBoule/ImpromptuModular/blob/master/README.md
but I wasn't sure it was the recommended way. Good to know!

P.S. If ever no one volunteers for the Library Teamneeded, I could perhaps pitch in, I would just need to learn about the "knowledge of submitting PRs" part, in particular relating to the mechanism in play in the repos folder; it is still unclear to me (I am a github rookie, so still much to learn!) :-)

@AndrewBelt AndrewBelt added plugin and removed plugin labels Mar 28, 2018
@MarcBoule
Copy link
Author

I have added a new module to my plugin and would like to request an update. The version should be bumped up to 0.6.1, and the source corresponds to my current master at
https://github.com/MarcBoule/ImpromptuModular
Thanks!

@mdemanett
Copy link
Contributor

@MarcBoule - you should update your Makefile to bump VERSION to 0.6.1. Your module went out to the package manager already as 0.6.0 -- so the review/build process needs a version bump to work, and the new version needs to match VERSION in the Makefile.

@AndrewBelt I reviewed the code and it's good...but will hold off on a PR pending the Makefile update. Set me straight if I've got this wrong. If I'm not wrong, looks like a few other modules requesting updates will need to do the same thing (bump their version to 0.6.1) -- Valley and Amalgamated are examples.

@AndrewBelt
Copy link
Member

@mdemanett Looks like you're all correct. Yes, everyone needs to update their version or the plugin manager will not trigger an update.

@MarcBoule
Copy link
Author

My bad, I totally forgot about that one. thanks to both of you for the follow up, it is now fixed. 👍

@MarcBoule
Copy link
Author

MarcBoule commented Apr 1, 2018

By the way, it's good that our Plugin's issue remain permanently open, it helps to remember these things so they don't happen again. And to answer a question from @AndrewBelt in another issue, if the author accidentally closes his or her Plugin issue, they can indeed re-open it.

This was referenced Apr 1, 2018
@AndrewBelt
Copy link
Member

Updated build, close until you have a new update.

@MarcBoule
Copy link
Author

Sounds good!

@MarcBoule
Copy link
Author

I have added a new sequencer to my plugin and would like to request an update. The new version is 0.6.2, and the source corresponds to my current master at
https://github.com/MarcBoule/ImpromptuModular
My makefile was also updated to 0.6.2. Thanks!

@MarcBoule MarcBoule reopened this Apr 17, 2018
@phdsg
Copy link
Contributor

phdsg commented Apr 18, 2018

updated build.

@MarcBoule
Copy link
Author

Thanks!

@MarcBoule
Copy link
Author

Major redesign of Phrase-Seq-16, and would like to request an update please.
The new version is 0.6.3, and the source corresponds to my current master at
https://github.com/MarcBoule/ImpromptuModular
My makefile was also updated to 0.6.3. Thanks!

@phdsg
Copy link
Contributor

phdsg commented Apr 27, 2018

Updated build.

@MarcBoule
Copy link
Author

Thanks!

@MarcBoule
Copy link
Author

Hi, could the following dontation link be added in ImpromptuModular.json please:
"donateUrl": "https://www.paypal.me/marcboule",
Thank you!

@MarcBoule
Copy link
Author

Requesting an update please, now at v2.4.2.
Deprecated the SMS16 module, created a new module called NoteEcho, made minor changes to the sequencers to make them compatible with NoteEcho, and other very minor changes to BigButton and AdaptiveQuantizer.
The head of master branch can be pulled.
Thanks!

@cschol cschol reopened this Feb 8, 2024
@cschol
Copy link
Collaborator

cschol commented Feb 9, 2024

Build failure on macOS platform: MarcBoule/ImpromptuModular#73

@MarcBoule
Copy link
Author

Requesting an update please, now at v2.4.3.
Small tweaks and bugfixes. The head of master branch can be pulled.
Thanks!

@cschol cschol reopened this Mar 30, 2024
@cschol
Copy link
Collaborator

cschol commented Mar 30, 2024

@MarcBoule please update the version in the plugin.json to 2.4.3.

@MarcBoule
Copy link
Author

Ah, forgot to do a push, sorry about that, done now!

@AndrewBelt
Copy link
Member

@MarcBoule said via email

If this plugin ceases to be compatible with the current version of VCV Rack, and no contact can be established with the plugin's author within a reasonable time-frame (a few weeks or so), then this policy statement allows the owner(s) of VCV Rack to designate a new developer who can fork the project and maintain its inclusion in the VCV Library

@MarcBoule
Copy link
Author

Requesting an update please, now at v2.5.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

5 participants