Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valley #407

Closed
ValleyAudio opened this issue Mar 31, 2018 · 112 comments
Closed

Valley #407

ValleyAudio opened this issue Mar 31, 2018 · 112 comments
Labels
plugin

Comments

@ValleyAudio
Copy link
Contributor

name: Valley
author: ValleyAudio
license: BSD-3-Clause, GPL-3.0-only
contactEmail: [email protected]
pluginUrl: https://github.com/ValleyAudio/ValleyRackFree
authorUrl: https://github.com/ValleyAudio/ValleyRackFree
manualUrl: https://github.com/ValleyAudio/ValleyRackFree
sourceUrl: https://github.com/ValleyAudio/ValleyRackFree
donateUrl: https://www.paypal.me/valleyvcv
latestVersion: 0.6.1
@phdsg
Copy link
Contributor

phdsg commented Apr 1, 2018

Makefile in all branches still has VERSION = 0.6.0

@ValleyAudio
Copy link
Contributor Author

@phdsg Now fixed.
Out of interest, which branch are you building from?

@phdsg
Copy link
Contributor

phdsg commented Apr 1, 2018

currently .gitmodules is set to v0.6.

@ValleyAudio
Copy link
Contributor Author

Can you switch to master as that's the most up to date? Or is that not best practice?

@phdsg
Copy link
Contributor

phdsg commented Apr 1, 2018

changed it. don't know about best practice, but most submodules point to the master branches.

@AndrewBelt
Copy link
Member

Doesn't really matter. Rack itself uses the v0.6 branch instead of master for the latest 0.6-compatible code.

AndrewBelt pushed a commit that referenced this issue Apr 1, 2018
@phdsg @AndrewBelt
Reviewed Version Updates: Bogaudio #396, moDllz #389, Valley #407 (#409)
0f4d1bd
@phdsg
Copy link
Contributor

phdsg commented Apr 1, 2018

btw. what's up with #385 ?

@AndrewBelt AndrewBelt mentioned this issue Apr 1, 2018
Closed
@ValleyAudio
Copy link
Contributor Author

@phdsg I was under the impression that Rack won't see my updated code (as in the updated submodules on the build teams side) unless it was "updated" to 0.6.1

@phdsg
Copy link
Contributor

phdsg commented Apr 1, 2018

@ValleyAudio for your next update just reuse this issue here.

discussion on that: #352 (comment)

@ValleyAudio
Copy link
Contributor Author

Ah I missed that part

@AndrewBelt
Copy link
Member

Added 97485b1 to README for clarity

AndrewBelt pushed a commit that referenced this issue Apr 1, 2018
@phdsg @AndrewBelt
New Repo: mscHack... (#412)
dd7e928 
* Reviewed Version Updates: Bogaudio #396, moDllz #389, Valley #407

* added mscHack Repo, Submodule. lotsa code, so maybe someone else could have a 2nd look.

* mscHack version update
@ValleyAudio
Copy link
Contributor Author

@phdsg I've added new updates to my code. You can use the 0.6.1 version number in the manifest since that's a real update.

"repoVersion" : 0.6.1

@phdsg
Copy link
Contributor

phdsg commented Apr 1, 2018

mhh, the current manifest already has the repoVersion bumped.
i'm a bit unsure if i should just update the repo pointer at this point or if you should bump to 0.6.2. @AndrewBelt ?!

@ValleyAudio
Copy link
Contributor Author

@phdsg I should just probably go to 0.6.2 to save headaches here if that helps? Sorry for this problem guys.

@phdsg
Copy link
Contributor

phdsg commented Apr 1, 2018

@ValleyAudio no problem. it's good that we have these cases, so everything can be ironed out for a flawless workflow in the future.
anyway, i suspect the new commits have to be reviewed either way.
as there's no build of 0.6.1 yet it probably doesn't matter what version the next build has as long as it's higher than the latestVersion.

@ValleyAudio
Copy link
Contributor Author

ValleyAudio commented Apr 1, 2018 •
edited
Loading

@phdsg okay, I'll push the changes then so that we're all back on the same page again.

"repoVersion" : 0.6.2

@phdsg
Copy link
Contributor

phdsg commented Apr 1, 2018

@ValleyAudio allright. i probably won't get to update it today anymore though.

@ValleyAudio
Copy link
Contributor Author

@phdsg All in good time :)

AndrewBelt pushed a commit that referenced this issue Apr 1, 2018
@phdsg @AndrewBelt
cf: reviewed manifest and repo (#414)
325247b 
* Reviewed Version Updates: Bogaudio #396, moDllz #389, Valley #407

* added mscHack Repo, Submodule. lotsa code, so maybe someone else could have a 2nd look.

* mscHack version update

* cf: Update repo and manifest
AndrewBelt pushed a commit that referenced this issue Apr 2, 2018
@phdsg @AndrewBelt
Reviewed Version Update: Valley (#416)
43bb9ce 
* Reviewed Version Updates: Bogaudio #396, moDllz #389, Valley #407

* added mscHack Repo, Submodule. lotsa code, so maybe someone else could have a 2nd look.

* mscHack version update

* cf: Update repo and manifest

* Reviewed Version Update: Valley
@phdsg
Copy link
Contributor

phdsg commented Apr 2, 2018

updated in 43bb9ce

AndrewBelt pushed a commit that referenced this issue Apr 2, 2018
@phdsg @AndrewBelt
manifest & repo update: Bidoo (#419)
c72ef30 
* Reviewed Version Updates: Bogaudio #396, moDllz #389, Valley #407

* added mscHack Repo, Submodule. lotsa code, so maybe someone else could have a 2nd look.

* mscHack version update

* cf: Update repo and manifest

* Reviewed Version Update: Valley

* Bidoo 0.6.1 Manifest & Repo _prereview_

* moDllz: update Repo to 0.6.1

* Revert "moDllz: update Repo to 0.6.1"

This reverts commit 0bd1f40.
AndrewBelt pushed a commit that referenced this issue Apr 2, 2018
@phdsg @AndrewBelt
New Repo: NonLinearInstruments (#422)
e83f11c 
* Reviewed Version Updates: Bogaudio #396, moDllz #389, Valley #407

* added mscHack Repo, Submodule. lotsa code, so maybe someone else could have a 2nd look.

* mscHack version update

* cf: Update repo and manifest

* Reviewed Version Update: Valley

* Bidoo 0.6.1 Manifest & Repo _prereview_

* moDllz: update Repo to 0.6.1

* Revert "moDllz: update Repo to 0.6.1"

This reverts commit 0bd1f40.

* new repo: NonLinearInstruments, pre-review

* manifest update: NonLinearInstruments

* Update NonLinearInstruments.json
AndrewBelt pushed a commit that referenced this issue Apr 2, 2018
@phdsg @AndrewBelt
repo and manifest update: Ohmer 0.6.2 (#424)
fc3039e 
* Reviewed Version Updates: Bogaudio #396, moDllz #389, Valley #407

* added mscHack Repo, Submodule. lotsa code, so maybe someone else could have a 2nd look.

* mscHack version update

* cf: Update repo and manifest

* Reviewed Version Update: Valley

* Bidoo 0.6.1 Manifest & Repo _prereview_

* moDllz: update Repo to 0.6.1

* Revert "moDllz: update Repo to 0.6.1"

This reverts commit 0bd1f40.

* new repo: NonLinearInstruments, pre-review

* manifest update: NonLinearInstruments

* Update NonLinearInstruments.json

* repo update: Ohmer 0.6.2

* Update Ohmer.json
AndrewBelt pushed a commit that referenced this issue Apr 2, 2018
@phdsg @AndrewBelt
repo and manifest update: FrozenWasteland 0.6.2 (#426)
6ab5909 
* Reviewed Version Updates: Bogaudio #396, moDllz #389, Valley #407

* added mscHack Repo, Submodule. lotsa code, so maybe someone else could have a 2nd look.

* mscHack version update

* cf: Update repo and manifest

* Reviewed Version Update: Valley

* Bidoo 0.6.1 Manifest & Repo _prereview_

* moDllz: update Repo to 0.6.1

* Revert "moDllz: update Repo to 0.6.1"

This reverts commit 0bd1f40.

* new repo: NonLinearInstruments, pre-review

* manifest update: NonLinearInstruments

* Update NonLinearInstruments.json

* repo update: Ohmer 0.6.2

* Update Ohmer.json

* repo update: FrozenWasteland 0.6.2

* Update FrozenWasteland.json
AndrewBelt pushed a commit that referenced this issue Apr 2, 2018
@phdsg @AndrewBelt
repo and manifest update: AmalgamatedHarmonics 0.6.1 (#427)
918539d 
* Reviewed Version Updates: Bogaudio #396, moDllz #389, Valley #407

* added mscHack Repo, Submodule. lotsa code, so maybe someone else could have a 2nd look.

* mscHack version update

* cf: Update repo and manifest

* Reviewed Version Update: Valley

* Bidoo 0.6.1 Manifest & Repo _prereview_

* moDllz: update Repo to 0.6.1

* Revert "moDllz: update Repo to 0.6.1"

This reverts commit 0bd1f40.

* new repo: NonLinearInstruments, pre-review

* manifest update: NonLinearInstruments

* Update NonLinearInstruments.json

* repo update: Ohmer 0.6.2

* Update Ohmer.json

* repo update: FrozenWasteland 0.6.2

* Update FrozenWasteland.json

* repo update: AmalgamatedHarmonics 0.6.1

* manifest update: AmalgamatedHarmonics 0.6.1
@ValleyAudio
Copy link
Contributor Author

version : 2.4.2
branch : main
hash : b23bb2e9ce9faba520db903eb7294cd9946edf64

@cschol cschol reopened this Sep 28, 2023
cschol added a commit that referenced this issue Sep 30, 2023
@cschol
Review and update Valley to version 2.4.2. #407
0d868ba
@ValleyAudio
Copy link
Contributor Author

version : 2.4.3
branch : main
hash : d4a9ea5628479f4440458577f53ed6b3ceaafdd3

@cschol cschol reopened this Oct 7, 2023
cschol added a commit that referenced this issue Oct 7, 2023
@cschol
Review and update Valley to version 2.4.3. #407
efc1ee1
@ValleyAudio
Copy link
Contributor Author

version : 2.4.4
branch : main
hash : 9a43da65e74c08a7b113135498329e083fd0c16c

@cschol cschol reopened this Oct 29, 2023
cschol added a commit that referenced this issue Oct 29, 2023
@cschol
Review and update Valley to version 2.4.4. #407
41336d4
@ValleyAudio
Copy link
Contributor Author

version : 2.4.5
branch : main
hash : 86f02e431136a7f5c96a872b99b7115b7e133e05

@cschol cschol reopened this Nov 11, 2023
cschol added a commit that referenced this issue Nov 11, 2023
@cschol
Review and update Valley to version 2.4.5. #407
e5fc137
@cschol cschol moved this to Up-to-date in VCV Rack Open-source Plugins Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin
Projects
VCV Rack Open-source Plugins
Status: Up-to-date
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mdemanett @AndrewBelt @cschol @phdsg @ValleyAudio