Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][ModalPageHeader]: Возможность управлять поведением separator самостоятельно #4546

Closed
inomdzhon opened this issue Mar 21, 2023 · 1 comment · Fixed by #6277
Closed

[Feature][ModalPageHeader]: Возможность управлять поведением separator самостоятельно #4546

inomdzhon opened this issue Mar 21, 2023 · 1 comment · Fixed by #6277
Assignees
@BlackySoul
Labels
cmp:modal-page-header type:feature v6.0.0-beta.3

Comments

@inomdzhon
Copy link
Contributor

Описание

Сейчас параметр separator у ModalPageHeader завязан на платформу VKCOM. Если я передам separator={true}, то он покажется только для platform="vkcom".

Скриншоты

image image image
@inomdzhon inomdzhon added type:feature design Нужно участие команды дизайна cmp:modal-page-header labels Mar 21, 2023
@inomdzhon inomdzhon added this to VKUI Mar 21, 2023
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Mar 21, 2023
@BlackySoul BlackySoul mentioned this issue Dec 14, 2023
Merged
4 tasks
@BlackySoul BlackySoul self-assigned this Dec 21, 2023
@BlackySoul BlackySoul moved this from 🗃 Backlog to 👀 In Review in VKUI Dec 21, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Dec 28, 2023
@inomdzhon inomdzhon removed the design Нужно участие команды дизайна label Dec 29, 2023
@inomdzhon
Copy link
Contributor Author

Теперь разделитель есть всегда. Если не нужен, то можно передать noSeparator (см. #6277)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BlackySoul BlackySoul

Labels
cmp:modal-page-header type:feature v6.0.0-beta.3
Projects
VKUI
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(PanelHeader): rename boolean props VKCOM/VKUI
3 participants
@inomdzhon @BlackySoul @Zaycevq