feat(PanelHeader): rename boolean props #6277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit deb5322:
|
e2e tests |
👀 Docs deployed
Commit deb5322 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6277 +/- ##
=======================================
Coverage 81.25% 81.26%
=======================================
Files 326 326
Lines 10104 10108 +4
Branches 3393 3397 +4
=======================================
+ Hits 8210 8214 +4
Misses 1894 1894
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
reviewed
Dec 14, 2023
BlackySoul
force-pushed
the
feat/6264/PanelHeader_rename_separator_props
branch
from
4ad3b89 to
5cc0c27
Compare
SevereCloud
previously approved these changes
Dec 15, 2023
mendrew
reviewed
Dec 15, 2023
mendrew
previously approved these changes
Dec 18, 2023
inomdzhon
previously approved these changes
Dec 18, 2023
mendrew
previously approved these changes
Dec 21, 2023
inomdzhon
previously approved these changes
Dec 21, 2023
Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
BlackySoul
dismissed stale reviews from Zaycevq, inomdzhon, and mendrew
via
deb5322
BlackySoul
force-pushed
the
feat/6264/PanelHeader_rename_separator_props
branch
from
efc5b20 to
deb5322
Compare
inomdzhon
approved these changes
Dec 28, 2023
mendrew
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separatorсамостоятельно #4546- [ ] Unit-тестыОписание
Проблема: проп
separatorвPanelHeaderтак же аффектитspacingмежду шапкой и контентом на не мобильных экранах, из-за этого могли ловить вот такое невалидное поведение:Изменения
Panel, связанные сvisorиseparator, они дублируют друг другаView, сейчас страница не открывается совсемPanelHeaderпропdelimiter, который позволяет управлять разделителями.