Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][BREAKING CHANGE][ConfigProvider]: В режиме embedded класс с названием платформы (темы) добавляется на body #4810

Closed
Tracked by #5868
eugpoloz opened this issue Apr 11, 2023 · 1 comment · Fixed by #6263
Closed
Tracked by #5868

[Bug][BREAKING CHANGE][ConfigProvider]: В режиме embedded класс с названием платформы (темы) добавляется на body #4810

eugpoloz opened this issue Apr 11, 2023 · 1 comment · Fixed by #6263
Assignees
@inomdzhon
Labels
breaking-change cmp:config-provider type:bug v6.0.0-beta.2
Milestone
v6.0.0

Comments

@eugpoloz
Copy link
Contributor

Проблема:

В режиме mode="embedded" класс с названием платформы (темы) добавляется все равно на body

Как решить:

Перенести навешивание класса из ConfigProvider в AppRoot.
@eugpoloz eugpoloz added this to the v6 milestone Apr 11, 2023
@eugpoloz eugpoloz added this to VKUI Apr 11, 2023
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Apr 11, 2023
@inomdzhon inomdzhon self-assigned this Nov 27, 2023
@inomdzhon inomdzhon mentioned this issue Nov 28, 2023
Closed
36 tasks
inomdzhon added a commit that referenced this issue Nov 28, 2023
@inomdzhon
tech(ConfigProvider): resolve TODO
c2c565c 
- fix #4810

migration_v6.md уже обновлён.

Только нужно добавить про удаление onDetectAppearanceByBridge
inomdzhon added a commit that referenced this issue Nov 28, 2023
@inomdzhon
fixup! tech(ConfigProvider): resolve TODO
9d0b8b0 
- fix #4810

migration_v6.md уже обновлён.

Только нужно добавить про удаление onDetectAppearanceByBridge
@inomdzhon inomdzhon moved this from 🗃 Backlog to 🔜 To do in VKUI Nov 30, 2023
@inomdzhon inomdzhon moved this from 🔜 To do to 🔧 In progress in VKUI Dec 6, 2023
@inomdzhon inomdzhon mentioned this issue Dec 12, 2023
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from 🔧 In progress to ✅ Done in VKUI Dec 13, 2023
@vkcom-publisher
Copy link
Contributor

✅ v6.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inomdzhon inomdzhon

Labels
breaking-change cmp:config-provider type:bug v6.0.0-beta.2
Projects
VKUI
Archived in project
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

refactor(AppRoot): fix appearance cleanup for mode="embedded" VKCOM/VKUI
3 participants
@inomdzhon @eugpoloz @vkcom-publisher