Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: v6.0.0-beta.1 сломан SSR для appearance #6240

Closed
SevereCloud opened this issue Dec 8, 2023 · 1 comment · Fixed by #6243
Closed

[Bug]: v6.0.0-beta.1 сломан SSR для appearance #6240

SevereCloud opened this issue Dec 8, 2023 · 1 comment · Fixed by #6243
Assignees
@inomdzhon
Labels
cmp:config-provider ssr type:bug v6.0.0-beta.2
Milestone
v6.0.0

Comments

@SevereCloud
Copy link
Contributor

Описание

Server Error
TypeError: Cannot read properties of undefined (reading 'matchMedia')

This error happened while generating the page. Any console logs will be displayed in the terminal window.
Call Stack
matchMedia
node_modules/@vkontakte/vkui/dist/cssm/hooks/useAutoDetectAppearance.js (15:22)

Версия

6.0.0-beta.1

В каких браузерах воспроизводится проблема?

Chrome

Шаги воспроизведения

Использовать ConfigProvider не передавая свойств

Ожидаемое поведение

No response

Скриншоты

No response

Пример с воспроизведением

VKUI/packages/vkui/src/hooks/useAutoDetectAppearance.tsx

Line 19 in e421dcb

return window!.matchMedia('(prefers-color-scheme: dark)')?.matches ? 'dark' : 'light';

@SevereCloud SevereCloud added this to VKUI Dec 8, 2023
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Dec 8, 2023
@inomdzhon inomdzhon added the ssr label Dec 8, 2023
@inomdzhon inomdzhon self-assigned this Dec 8, 2023
@inomdzhon inomdzhon moved this from 🗃 Backlog to 🔧 In progress in VKUI Dec 8, 2023
@inomdzhon inomdzhon added this to the v6 milestone Dec 8, 2023
@inomdzhon inomdzhon mentioned this issue Dec 8, 2023
Merged
2 tasks
@inomdzhon inomdzhon moved this from 🔧 In progress to 👀 In Review in VKUI Dec 8, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Dec 11, 2023
@vkcom-publisher
Copy link
Contributor

✅ v6.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inomdzhon inomdzhon

Labels
cmp:config-provider ssr type:bug v6.0.0-beta.2
Projects
VKUI
Archived in project
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

fix(useAutoDetectAppearance): rm window from useState VKCOM/VKUI
3 participants
@inomdzhon @SevereCloud @vkcom-publisher