fix(useAutoDetectAppearance): rm window from useState #6243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7c623f7:
|
e2e tests |
👀 Docs deployed
Commit 7c623f7 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6243 +/- ##
=======================================
Coverage 81.14% 81.14%
=======================================
Files 324 324
Lines 10091 10090 -1
Branches 3386 3386
=======================================
Hits 8188 8188
+ Misses 1903 1902 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BlackySoul
previously approved these changes
Dec 11, 2023
SevereCloud
reviewed
Dec 11, 2023
mendrew
approved these changes
Dec 11, 2023
SevereCloud
approved these changes
Dec 11, 2023
inomdzhon
deleted the
imirdzhamolov/issue6240/fix-useAutoDetectAppearance-ssr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Не учёл, что
useState()вызывается и на сервере. Первое, что может придти в голову – это проверять вuseStateсуществует лиwindow, но так сделать не можем, т.к. на клиенте, если пользователь не передалappearance, то условие отработает удовлетворительно и в первый мы получим автоматическое определениеappearance, тем самым у нас уже будет разница между клиентом и сервером.В
useStateтеперь возвращаем либо пользовательскийappearance, либо'light'по умолчанию.В самом эффекте добавил условие для
window, чтобы убрать неочевидный Non-null Assertion Operator (!).