Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][AspectRatio]: добавить возможность принимать string в свойстве ratio #8064

Closed
inomdzhon opened this issue Dec 11, 2024 · 1 comment · Fixed by #8088
Closed

[Feature][AspectRatio]: добавить возможность принимать string в свойстве ratio #8064

inomdzhon opened this issue Dec 11, 2024 · 1 comment · Fixed by #8088
Assignees
@EldarMuhamethanov
Labels
cmp:aspect-ratio type:feature
Milestone
v7.1.0

Comments

@inomdzhon
Copy link
Contributor

inomdzhon commented Dec 11, 2024 •
edited
Loading

Описание

Есть потребность передавать строку в свойство, например, для передачи CSS переменной var(--<name>), calc(<value>) или <value><unit>.

export interface AspectRatioProps extends Omit<RootComponentProps<HTMLElement>, 'baseClassName'> {
-  ratio: number;
+  ratio: number | string;
}

Скриншоты

No response
@inomdzhon inomdzhon added this to VKUI Dec 11, 2024
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Dec 11, 2024
@inomdzhon inomdzhon changed the title [Feature][AspectRatio]: добавить возможность принимать CSS переменную в свойстве ratio [Feature][AspectRatio]: добавить возможность принимать string в свойстве ratio Dec 12, 2024
@inomdzhon inomdzhon added this to the v7.1.0 milestone Dec 12, 2024
@EldarMuhamethanov EldarMuhamethanov self-assigned this Dec 16, 2024
@EldarMuhamethanov EldarMuhamethanov moved this from 🗃 Backlog to 🔧 In progress in VKUI Dec 16, 2024
@EldarMuhamethanov EldarMuhamethanov moved this from 🔧 In progress to 👀 In Review in VKUI Dec 16, 2024
@EldarMuhamethanov EldarMuhamethanov mentioned this issue Dec 16, 2024
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Dec 16, 2024
@vkcom-publisher
Copy link
Contributor

✅ v7.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
cmp:aspect-ratio type:feature
Projects
VKUI
Archived in project
Milestone
v7.1.0
Development

Successfully merging a pull request may close this issue.

feat(AspectRatio): extract ratio prop type VKCOM/VKUI
3 participants
@inomdzhon @EldarMuhamethanov @vkcom-publisher