Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AspectRatio): extract ratio prop type #8088

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Документация фичи
  • Release notes

Описание

Есть потребность передавать строку в свойство, например, для передачи CSS переменной var(--<name>), calc(<value>) или <value><unit>.

Изменения

Добавлена возожность прокинуть строку в свойство ratio компонента AspectRatio

Release notes

Улучшения

  • AspectRatio: Добавлена возможность прокинуть в свойство ratio значения в виде строки

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 16, 2024 12:05
Copy link
Contributor

size-limit report 📦

Path Size
JS 388.91 KB (+0.01% 🔺)
JS (gzip) 117.99 KB (+0.01% 🔺)
JS (brotli) 97.12 KB (-0.03% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 341.44 KB (0%)
CSS (gzip) 42.28 KB (0%)
CSS (brotli) 33.67 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 09abdad

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.60%. Comparing base (a739d46) to head (09abdad).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8088   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         398      398           
  Lines       11321    11322    +1     
  Branches     3728     3729    +1     
=======================================
+ Hits        10823    10824    +1     
  Misses        498      498           
Flag Coverage Δ
unittests 95.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@EldarMuhamethanov EldarMuhamethanov merged commit 5cb14c4 into master Dec 16, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8064/extract-aspect-ratio-type branch December 16, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants