fix(AspectRatio): children prop passing #5864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After fd49482 we stop passing children to the component.
mendrew
added
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e21d1f8:
|
SevereCloud
approved these changes
Sep 25, 2023
e2e tests |
👀 Docs deployed
Commit e21d1f8 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5864 +/- ##
=======================================
Coverage 81.18% 81.18%
=======================================
Files 299 299
Lines 9189 9189
Branches 3120 3120
=======================================
Hits 7460 7460
Misses 1729 1729
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
BlackySoul
approved these changes
Sep 25, 2023
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 25, 2023
After fd49482 we stop passing children to the component.
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 25, 2023
After fd49482 we stop passing children to the component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
После fd49482 мы перестали передавать
childrenвRootComponent.Проверил все изменения из того коммита - это единственное место.
В результате чего на странице AspectRatio начиная с версии 5.8.0 мы не видим картинок.
