-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change getRootRefTest check for null #5916
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8767dd0:
|
e2e tests |
👀 Docs deployed
Commit 8767dd0 |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5916 +/- ##
==========================================
+ Coverage 79.17% 79.18% +0.01%
==========================================
Files 304 304
Lines 9507 9513 +6
Branches 3216 3216
==========================================
+ Hits 7527 7533 +6
Misses 1980 1980
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* fix: change getRootRefTest check for null * fix: type import
* fix: change getRootRefTest check for null * fix: type import
✅ v5.9.2 🎉 |
- [ ] e2e-тесты- [ ] Дизайн-ревьюОписание
Из-за проверки только на
null
вgetRootRefTest
ловили ложно-положительные результаты тестовИзменения
Там, где проверка не нужна, она была убрана
В некоторых компонентах на рутовые компоненты по ошибке прокидывается
getRoot
, оставила комменты, что вv6
нужно это убратьВ
CustomScrollViewProps
поправлены типы