Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change getRootRefTest check for null #5916

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

BlackySoul
Copy link
Contributor

  • Unit-тесты

- [ ] e2e-тесты

- [ ] Дизайн-ревью

Описание

Из-за проверки только на null в getRootRefTest ловили ложно-положительные результаты тестов

Изменения

Там, где проверка не нужна, она была убрана
В некоторых компонентах на рутовые компоненты по ошибке прокидывается getRoot, оставила комменты, что в v6 нужно это убрать
В CustomScrollViewProps поправлены типы

@BlackySoul BlackySoul requested a review from a team as a code owner October 4, 2023 17:18
@BlackySoul BlackySoul self-assigned this Oct 4, 2023
@BlackySoul BlackySoul added this to the v5.9.2 milestone Oct 4, 2023
@BlackySoul BlackySoul added v5 Автоматизация: PR продублируется в ветку v5 patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

size-limit report 📦

Path Size
JS 323.41 KB (+0.09% 🔺)
JS (gzip) 98.39 KB (+0.08% 🔺)
JS (brotli) 81.36 KB (-0.02% 🔽)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 278.41 KB (0%)
CSS (gzip) 36.1 KB (0%)
CSS (brotli) 28.63 KB (0%)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8767dd0:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

👀 Docs deployed

Commit 8767dd0

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b15428d) 79.17% compared to head (8767dd0) 79.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5916      +/-   ##
==========================================
+ Coverage   79.17%   79.18%   +0.01%     
==========================================
  Files         304      304              
  Lines        9507     9513       +6     
  Branches     3216     3216              
==========================================
+ Hits         7527     7533       +6     
  Misses       1980     1980              
Flag Coverage Δ
unittests 79.18% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/vkui/src/components/Alert/Alert.tsx 98.36% <ø> (ø)
...kui/src/components/CalendarRange/CalendarRange.tsx 56.45% <ø> (ø)
...es/vkui/src/components/ChipsSelect/ChipsSelect.tsx 83.64% <100.00%> (ø)
...c/components/CustomScrollView/CustomScrollView.tsx 66.66% <ø> (ø)
...ages/vkui/src/components/FormLayout/FormLayout.tsx 100.00% <100.00%> (ø)
...src/components/ModalPageHeader/ModalPageHeader.tsx 100.00% <100.00%> (ø)
...onents/VisuallyHiddenInput/VisuallyHiddenInput.tsx 90.00% <100.00%> (+2.50%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BlackySoul BlackySoul merged commit 3aced02 into master Oct 5, 2023
@BlackySoul BlackySoul deleted the blackysoul/fix_getRootRef_test branch October 5, 2023 08:29
vkcom-publisher pushed a commit that referenced this pull request Oct 5, 2023
* fix: change getRootRefTest check for null

* fix: type import
vkcom-publisher pushed a commit that referenced this pull request Oct 5, 2023
* fix: change getRootRefTest check for null

* fix: type import
@vkcom-publisher
Copy link
Contributor

v5.9.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants