Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HorizontalCell): extends from TappableProps #5918

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

BlackySoul
Copy link
Contributor


- [ ] Unit-тесты
- [ ] e2e-тесты
- [ ] Дизайн-ревью

Описание

Не было возможности переопределить у HorizontalCell свойства от Tappable

Изменения

Сделали extends от TappableProps, исключая size и getRootRef, чтобы сойтись по типам

@BlackySoul BlackySoul requested a review from a team as a code owner October 5, 2023 05:33
@BlackySoul BlackySoul linked an issue Oct 5, 2023 that may be closed by this pull request
@BlackySoul BlackySoul added the v5 Автоматизация: PR продублируется в ветку v5 label Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

size-limit report 📦

Path Size
JS 323.13 KB (0%)
JS (gzip) 98.32 KB (0%)
JS (brotli) 81.38 KB (0%)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 278.41 KB (0%)
CSS (gzip) 36.1 KB (0%)
CSS (brotli) 28.63 KB (0%)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0683461:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

👀 Docs deployed

Commit 0683461

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b15428d) 79.17% compared to head (0683461) 79.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5918   +/-   ##
=======================================
  Coverage   79.17%   79.17%           
=======================================
  Files         304      304           
  Lines        9507     9507           
  Branches     3216     3216           
=======================================
  Hits         7527     7527           
  Misses       1980     1980           
Flag Coverage Δ
unittests 79.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...i/src/components/HorizontalCell/HorizontalCell.tsx 84.61% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul merged commit b74ced7 into master Oct 5, 2023
@BlackySoul BlackySoul deleted the feat/5917/HorizontalCell_extends_TappableProps branch October 5, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Расширить HorizontalCellProps до TappableProps
3 participants