Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SegmentedControl): add before #5959

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Oct 11, 2023

  • [ ] Unit-тесты визуал
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

Добавляем свойство before для SegmentedControl

Изменения

  • удалил немного лишних стилей
  • добавил свойство before

@SevereCloud SevereCloud requested a review from a team as a code owner October 11, 2023 13:13
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Oct 11, 2023
@SevereCloud SevereCloud self-assigned this Oct 11, 2023
@SevereCloud SevereCloud added this to the v5.10.0 milestone Oct 11, 2023
@SevereCloud SevereCloud requested a review from a team October 11, 2023 13:16
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 325.38 KB (-0.01% 🔽)
JS (gzip) 99.25 KB (+0.01% 🔺)
JS (brotli) 82.02 KB (-0.02% 🔽)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 254.93 KB (-0.08% 🔽)
CSS (gzip) 33.49 KB (-0.07% 🔽)
CSS (brotli) 27.15 KB (-0.08% 🔽)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a665526:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2715ada) 79.16% compared to head (a665526) 79.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5959      +/-   ##
==========================================
- Coverage   79.16%   79.16%   -0.01%     
==========================================
  Files         306      306              
  Lines        9548     9550       +2     
  Branches     3225     3227       +2     
==========================================
+ Hits         7559     7560       +1     
- Misses       1989     1990       +1     
Flag Coverage Δ
unittests 79.16% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/components/SegmentedControl/SegmentedControl.tsx 96.96% <100.00%> (ø)
.../SegmentedControlOption/SegmentedControlOption.tsx 92.30% <66.66%> (-7.70%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit a665526

@SevereCloud SevereCloud merged commit 17ff58b into master Oct 12, 2023
@SevereCloud SevereCloud deleted the SevereCloud/feat/SegmentedControl/add-before branch October 12, 2023 11:55
@vkcom-publisher
Copy link
Contributor

v5.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:segmented-control type:feature v5 Автоматизация: PR продублируется в ветку v5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants