docs(View): add info about correct Panel order #6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inomdzhon
added
docs
patch
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e5f42ac:
|
👀 Docs deployed
Commit e5f42ac |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6046 +/- ##
==========================================
+ Coverage 79.21% 79.36% +0.15%
==========================================
Files 305 305
Lines 9588 9615 +27
Branches 3244 3253 +9
==========================================
+ Hits 7595 7631 +36
+ Misses 1993 1984 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
reviewed
Oct 25, 2023
mendrew
previously approved these changes
Oct 26, 2023
github-actions
bot
added
the
pr-needs-work
|
PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно. |
eugpoloz
reviewed
Nov 13, 2023
Co-authored-by: Evgenia Polozova <[email protected]>
Co-authored-by: Evgenia Polozova <[email protected]>
Co-authored-by: Evgenia Polozova <[email protected]>
mendrew
previously approved these changes
Nov 13, 2023
Co-authored-by: Evgenia Polozova <[email protected]>
eugpoloz
approved these changes
Nov 13, 2023
mendrew
approved these changes
Nov 13, 2023
inomdzhon
removed
the
pr-needs-work
inomdzhon
removed
the
patch
vkcom-publisher
pushed a commit
that referenced
this pull request
Nov 13, 2023
* docs(View): add info about correct Panel order * fix(review): reword text about order * Update packages/vkui/src/components/View/Readme.md Co-authored-by: Evgenia Polozova <[email protected]> * Update packages/vkui/src/components/View/Readme.md Co-authored-by: Evgenia Polozova <[email protected]> * Update packages/vkui/src/components/View/Readme.md Co-authored-by: Evgenia Polozova <[email protected]> * Update packages/vkui/src/components/View/Readme.md Co-authored-by: Evgenia Polozova <[email protected]> --------- Co-authored-by: Evgenia Polozova <[email protected]>
| ✅ v5.10.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Из VKCOM/vk-mini-apps-router#230 выяснилось, что в документации отсутствует информацию о правильном порядке
PanelвоView, чтобы была корректная анимация вперёд/назад и восстанавливался скролл при возврате на предыдущую панель.@pasha-nikitin-2003 предложил расширить доку.