feat(ModalCard): add dismissButtonMode #6068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 656b877:
|
e2e tests |
👀 Docs deployed
Commit 656b877 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6068 +/- ##
==========================================
+ Coverage 79.38% 79.40% +0.01%
==========================================
Files 306 307 +1
Lines 9631 9642 +11
Branches 3261 3262 +1
==========================================
+ Hits 7646 7656 +10
- Misses 1985 1986 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
pr-needs-work
BlackySoul
removed
the
pr-needs-work
SevereCloud
previously approved these changes
Nov 15, 2023
BlackySoul
force-pushed
the
blackysoul/add_close_button_modal_card
branch
from
a4ed0af to
ed90c7a
Compare
inomdzhon
approved these changes
Nov 20, 2023
vkcom-publisher
pushed a commit
that referenced
this pull request
Nov 20, 2023
* feat(ModalCard): add dismissButtonMode * fix(ModalCard): resolve conflict + fix safe offset + add doc * CHORE: Update screenshots * fix(ModalCard): another spacing iteration * chore: update screenshots --------- Co-authored-by: GitHub Action <[email protected]>
| ✅ v5.10.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] Unit-тестыe2e-тесты
Дизайн-ревью
- [ ] Документация фичиОписание
Изменения
Добавлен
dismissButtonMode=inside|outsideдляModalCard, пока выбрана стратегия добавления безопасного места сверху