-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Boolean props to false values #6286
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6971a43:
|
e2e tests |
👀 Docs deployed
Commit 6971a43 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6286 +/- ##
==========================================
- Coverage 81.53% 81.21% -0.32%
==========================================
Files 324 324
Lines 10084 10088 +4
Branches 3379 3383 +4
==========================================
- Hits 8222 8193 -29
- Misses 1862 1895 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Роскошно! 🎇
ps: скриншоты упали
А там просто коммент не апдейтнулся, скриншоты все есть х) |
ну ладно, ладно..... тогда.... конфликтик в |
6cdce09
to
d742b32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Классно 🚀 , только одно замечание в migration guide.
Co-authored-by: Andrey Medvedev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
- [ ] Дизайн-ревьюОписание
Как и было сказано в дискуссии, улучшаем api, чтобы не было необходимости писать
booleanValue={false}
Изменения
Некоторые пропы, которые по умолчанию задавалась как
boolean
с дефолтовымtrue
значением, переименованы в идентичные, инвертированные по смыслу