Make sure we show focus when user navigates using Talkback #6366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use VisuallyHidden for input as it can be focusable as in talkback an element with VisuallyHidden is hidden and not focus around is visible.
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8fc7ca5:
|
e2e tests |
👀 Docs deployed
Commit 8fc7ca5 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6366 +/- ##
==========================================
- Coverage 81.26% 81.26% -0.01%
==========================================
Files 326 326
Lines 10108 10107 -1
Branches 3397 3397
==========================================
- Hits 8214 8213 -1
Misses 1894 1894
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Должно быть исправлено в #6365 |
mendrew
deleted the
mendrew/fix/3392/SegmentedControlOption/show-focus-in-talkback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SegmentedControl#3392Описание
Элементы с фокусом не видны через Android TalkBack если они спрятаны с помощью VisuallyHidden.
Изменения
Меняем
VisuallyHiddenна несколько другой подход, чтобы область фокуса была видна.