fix(SubnavigationBar): ignore falsy children #6442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 79aa726:
|
e2e tests |
👀 Docs deployed
Commit 79aa726 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6442 +/- ##
==========================================
+ Coverage 81.98% 82.00% +0.02%
==========================================
Files 327 327
Lines 10135 10149 +14
Branches 3412 3418 +6
==========================================
+ Hits 8309 8323 +14
Misses 1826 1826
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
previously approved these changes
Jan 24, 2024
inomdzhon
reviewed
Jan 24, 2024
packages/vkui/src/components/SubnavigationBar/SubnavigationBar.tsx
Outdated
Show resolved
Hide resolved
mendrew
approved these changes
Jan 24, 2024
inomdzhon
approved these changes
Jan 24, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Jan 24, 2024
* fix(SubnavigationBar): ignore falsy children * Fix review notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
Используем
hasReactNode(child), чтобы отфильтровать все пустые ноды