Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix selection in chrome #6447

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

BlackySoul
Copy link
Contributor


Описание

Исправляем такую работу подсветки в хроме:

chrome_light.mov

Изменения

Установка любого цвета, кроме black исправляет подсветку ¯\ (ツ)

Copy link
Contributor

👀 Docs deployed

Commit fcea204

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fcea204:

Sandbox Source
VKUI TypeScript Configuration

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c913f62) 82.00% compared to head (fcea204) 82.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6447   +/-   ##
=======================================
  Coverage   82.00%   82.00%           
=======================================
  Files         327      327           
  Lines       10149    10149           
  Branches     3418     3418           
=======================================
  Hits         8323     8323           
  Misses       1826     1826           
Flag Coverage Δ
unittests 82.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jan 25, 2024
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@inomdzhon
Copy link
Contributor

Эту react-simple-code-editor/react-simple-code-editor#109 тогда ребятам закрываем?)

@BlackySoul
Copy link
Contributor Author

Эту react-simple-code-editor/react-simple-code-editor#109 тогда ребятам закрываем?)

Я бы оставила, потому что навернулось все как раз из-за того, что поменяли ноды местами 🤔

@BlackySoul BlackySoul added this to the v6.0.1 milestone Jan 26, 2024
@BlackySoul BlackySoul merged commit f2ababe into master Jan 26, 2024
18 checks passed
@BlackySoul BlackySoul deleted the docs/3791/fix_code_selection branch January 26, 2024 04:17
vkcom-publisher pushed a commit that referenced this pull request Jan 26, 2024
@inomdzhon inomdzhon removed this from the v6.0.1 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Неподходящий цвет ::selection в блоках кода документации
4 participants