Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Interactive demo in docs #6508

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Feb 2, 2024

Описание

Прилетел фидбэк, что некоторые элементы (в частности IconButton) не реагируют на клики (в v5 версии реагировали).

Изменения

Добавляем noop на некоторые элементы доки, чтобы можно было посмотреть на hover/active-состояния

@BlackySoul BlackySoul added this to the v6.0.1 milestone Feb 2, 2024
@BlackySoul BlackySoul self-assigned this Feb 2, 2024
@BlackySoul BlackySoul requested a review from a team as a code owner February 2, 2024 16:08
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

size-limit report 📦

Path Size
JS 349.18 KB (+0.01% 🔺)
JS (gzip) 106.74 KB (+0.01% 🔺)
JS (brotli) 88.26 KB (+0.05% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 257.98 KB (0%)
CSS (gzip) 33.81 KB (0%)
CSS (brotli) 27.47 KB (0%)

Copy link

codesandbox-ci bot commented Feb 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d9b8611:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

github-actions bot commented Feb 2, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Feb 2, 2024

👀 Docs deployed

Commit d9b8611

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (939831d) 82.02% compared to head (d9b8611) 82.08%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6508      +/-   ##
==========================================
+ Coverage   82.02%   82.08%   +0.06%     
==========================================
  Files         328      328              
  Lines       10158    10159       +1     
  Branches     3420     3421       +1     
==========================================
+ Hits         8332     8339       +7     
+ Misses       1826     1820       -6     
Flag Coverage Δ
unittests 82.08% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️         ❤️
   ❤️   ❤️
      ❤️

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@BlackySoul BlackySoul merged commit 6b803ec into master Feb 5, 2024
27 checks passed
@BlackySoul BlackySoul deleted the blackysoul/fix_tappable_onclick branch February 5, 2024 11:41
vkcom-publisher pushed a commit that referenced this pull request Feb 5, 2024
@vkcom-publisher
Copy link
Contributor

v6.0.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants