fix(PullToRefresh): Stretch PullToRefresh horizontally #6613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to do that in 4a0f713
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 956507d |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6613 +/- ##
=======================================
Coverage 82.13% 82.13%
=======================================
Files 330 330
Lines 10177 10207 +30
Branches 3416 3428 +12
=======================================
+ Hits 8359 8384 +25
- Misses 1818 1823 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BlackySoul
reviewed
Feb 28, 2024
packages/vkui/src/components/PullToRefresh/PullToRefresh.e2e-playground.tsx
Outdated
Show resolved
Hide resolved
inomdzhon
approved these changes
Feb 28, 2024
BlackySoul
approved these changes
Feb 28, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Feb 28, 2024
Растягиваем PullToRefresh по высоте, чтобы контент мог занимать всю высоту панели. Одна из проблем была с `Placeholder` в режиме `stretched`, который переставал выравниваться по центру, если был обернут в `PullToRefresh`. Без жесткого кастома нельзя отцентрировать по вертикали `Placeholder` `stretched` при наличии `PullToRefresh` Пример где `PullToRefresh` ломал поведение `Placeholder` https://codesandbox.io/p/sandbox/bold-feather-hfjx23 Раньше мы уже исправляли это в 4a0f713, но в какой-то момент поведение сломалось.
Merged
| ✅ v5.10.1 🎉 |
| ✅ v6.0.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Растягиваем PullToRefresh по высоте, чтобы контент мог занимать всю высоту панели.
Одна из проблем была с
Placeholderв режимеstretched, который переставал выравниваться по центру, если был обернут вPullToRefresh. Без жесткого кастома нельзя отцентрировать по вертикалиPlaceholderstretchedпри наличииPullToRefreshПример где
PullToRefreshломал поведениеPlaceholderhttps://codesandbox.io/p/sandbox/bold-feather-hfjx23Раньше мы уже исправляли это в 4a0f713, но в какой-то момент поведение сломалось.
В v5 это тоже нужно занести.