Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch(v5): pr6663 #6666

Merged
merged 5 commits into from
Mar 12, 2024
Merged

patch(v5): pr6663 #6666

merged 5 commits into from
Mar 12, 2024

Conversation

mendrew
Copy link
Contributor

@mendrew mendrew commented Mar 7, 2024

@mendrew
Don't pass unused props to NativeSelect (#6663)
7912444 
Исключаем передачу неиспользуемых Select пропсов в NativeSelect.
@mendrew mendrew self-assigned this Mar 7, 2024
@mendrew mendrew requested a review from a team as a code owner March 7, 2024 10:08
@mendrew mendrew added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 372.41 KB (+0.05% 🔺)
JS (gzip) 112.22 KB (+0.05% 🔺)
JS (brotli) 91.04 KB (+0.06% 🔺)
JS import Div (tree shaking) 2.74 KB (0%)
CSS 286.21 KB (0%)
CSS (gzip) 36.69 KB (0%)
CSS (brotli) 29.2 KB (0%)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Mar 7, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

👀 Docs deployed

Commit 23f0160

@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v5@96041fe). Click here to learn what that means.

Additional details and impacted files 
@@          Coverage Diff          @@
##             v5    #6666   +/-   ##
=====================================
  Coverage      ?   80.66%           
=====================================
  Files         ?      314           
  Lines         ?    10880           
  Branches      ?     3390           
=====================================
  Hits          ?     8776           
  Misses        ?     2104           
  Partials      ?        0
Flag Coverage Δ
unittests 80.66% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

inomdzhon
inomdzhon requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

см. #6663 (comment)

@mendrew mendrew marked this pull request as draft March 11, 2024 08:55
@mendrew mendrew requested a review from inomdzhon March 12, 2024 09:23
@mendrew mendrew marked this pull request as ready for review March 12, 2024 09:23
@mendrew mendrew merged commit efffa23 into v5 Mar 12, 2024
47 checks passed
@mendrew mendrew deleted the mendrew/v5-patch-39192cc-pr6663 branch March 12, 2024 12:21
vkcom-publisher pushed a commit that referenced this pull request Mar 12, 2024
@mendrew @actions-user
patch(v5): pr6663 (#6666)
5993a1e 
Исключаем передачу неиспользуемых Select пропсов в NativeSelect
@inomdzhon inomdzhon modified the milestones: v6.5.1, v5.10.2 Aug 9, 2024
@inomdzhon
Copy link
Contributor

✅ v5.10.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevereCloud SevereCloud SevereCloud approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

@mendrew mendrew

Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
VKUI
Archived in project
Milestone
v5.10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mendrew @inomdzhon @SevereCloud