docs: don't mount icons on start #6691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- closed #6686 Сейчас в стайлгайде иконки монтируются сразу при открытии страницы. Это было сделано для копирования иконок в Frame. Данный способ серьезно замедляет открытие страницы и также монтирует очень большое количество DOM нод Избавился от монтирование иконок на старте и добавил обсервер на спрайт
SevereCloud
added
the
patch
👀 Docs deployed
Commit 696779c |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6691 +/- ##
=======================================
Coverage 82.25% 82.25%
=======================================
Files 331 331
Lines 10273 10276 +3
Branches 3439 3442 +3
=======================================
+ Hits 8450 8453 +3
Misses 1823 1823
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
approved these changes
Mar 14, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Mar 14, 2024
- closed #6686 Сейчас в стайлгайде иконки монтируются сразу при открытии страницы. Это было сделано для копирования иконок в Frame. Данный способ серьезно замедляет открытие страницы и также монтирует очень большое количество DOM нод Избавился от монтирование иконок на старте и добавил обсервер на спрайт
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Сейчас в стайлгайде иконки монтируются сразу при открытии страницы. Это было сделано для копирования иконок в Frame. Данный способ серьезно замедляет открытие страницы и также монтирует очень большое количество DOM нод
Изменения
Избавился от монтирование иконок на старте и добавил обсервер на спрайт
LCP (замедление cpu x6, M1) 13 сек -> 5.5 сек