fix(PullToRefresh): Prevent multiple calls of runRefreshing on iOS #6723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On iOS PullToRefresh can start refreshing earlier than on other platforms. We call runRefreshing() withing onTouchMove. Since refreshing is a state variable, it can't be updated earlier than another event of onTouchMove is called, so, we have to user ref flag to avoid triggering runRefreshing more than once.
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit dac4c48 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6723 +/- ##
==========================================
+ Coverage 82.35% 82.36% +0.01%
==========================================
Files 335 335
Lines 10332 10351 +19
Branches 3461 3467 +6
==========================================
+ Hits 8509 8526 +17
- Misses 1823 1825 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
approved these changes
Mar 19, 2024
SevereCloud
approved these changes
Mar 19, 2024
mendrew
deleted the
mendrew/6715/fix/PullToRefresh/prevent-multiple-calls-of-run-refreshing
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Mar 19, 2024
На iOS мы вызываем `runRefreshing` внутри `onTouchMove` обработчика, который может вызываеться чаще чем обновляется состояние refreshing в стейте компонента. https://github.com/VKCOM/VKUI/blob/78e4cb5a5fe44fda8bbe87d079156566b2aa6ce9/packages/vkui/src/components/PullToRefresh/PullToRefresh.tsx#L222-L224 Это в свою очередь влечет за собой двойной вызов `onRefresh`. Изменения - добавляем состояние вызова `runRefreshing()` через ref, чтобы избежать повторного вызова `runRefreshing`. Cбрасываем состояние в обработчике onTouchEnd(). Это локальная проблема конкретного условия, что runRefreshing() на iOS вызывается в определённый момент ещё до конца жеста, поэтому и ref используем только в одном месте.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
На iOS мы вызываем
runRefreshingвнутриonTouchMoveобработчика, который может вызываеться чаще чем обновляется состояние refreshing в стейте компонента.VKUI/packages/vkui/src/components/PullToRefresh/PullToRefresh.tsx
Lines 222 to 224 in 78e4cb5
Это в свою очередь влечет за собой двойной вызов
onRefresh.Изменения
runRefreshing()через ref, чтобы избежать повторного вызоваrunRefreshing. Cбрасываем состояние в обработчике onTouchEnd().Это локальная проблема конкретного условия, что runRefreshing() на iOS вызывается в определённый момент ещё до конца жеста, поэтому и ref используем только в одном месте.