Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ImageBasePositionedComponent): add subcomponent to positioning component in Image #7166

Merged
merged 28 commits into from
Dec 11, 2024
Merged

feat(ImageBasePositionedComponent): add subcomponent to positioning component in Image #7166

merged 28 commits into from
Dec 11, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Jul 10, 2024 •
edited
Loading

  • Unit-тесты
  • Документация фичи

Описание

Нужно добавить сабкомпонент для компонента Image для позиционированирования компонентов внутри Image.

Изменения

  • Добавил сабкомпонент ImageBaseFloatElement для абсолютного позиционирования компонентов в компоненте Image.
  • Добавил тесты для компонента
  • Добавил стори для компонента
  • Добавил использование компонента в документацию

Release notes

Новые компоненты

  • Image: Добавлен сабкомпонент Image.FloatElement для позиционирования компонента относительно картинки

@EldarMuhamethanov
feat(ImageBasePositionedComponent): add subcomponent to positioning c…
1621520 
…omponent in Image

- Добавил сабкомпонент ImageBasePositionedComponent для абсолютного позиционирования компонентов в компоненте Image.
- Добавил тесты для компонента
- Добавил стори для компонента
- Добавил использование компонента в документацию
@EldarMuhamethanov
Merge branch 'master' into e.muhamethanov/6924/image-overlay-components
9844cbd
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner July 10, 2024 09:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 389.89 KB (+0.75% 🔺)
JS (gzip) 117.81 KB (+0.62% 🔺)
JS (brotli) 96.97 KB (+0.52% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 340.57 KB (+1.1% 🔺)
CSS (gzip) 42.16 KB (+0.85% 🔺)
CSS (brotli) 33.6 KB (+0.84% 🔺)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jul 10, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

👀 Docs deployed

Commit 4ab0a62

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (334e5b2) to head (4ab0a62).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7166      +/-   ##
==========================================
+ Coverage   95.51%   95.54%   +0.02%     
==========================================
  Files         396      398       +2     
  Lines       11235    11306      +71     
  Branches     3720     3734      +14     
==========================================
+ Hits        10731    10802      +71     
  Misses        504      504
Flag Coverage Δ
unittests 95.54% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mendrew
mendrew reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит здорово.

Я так понимаю, что он сразу сделан с возможностью использовать несколько Image.PositionedComponent. 👍

Оставил пару комментариев.

.../vkui/src/components/ImageBase/ImageBasePositionedComponent/ImageBasePositionedComponent.tsx Outdated Show resolved Hide resolved
.../vkui/src/components/ImageBase/ImageBasePositionedComponent/ImageBasePositionedComponent.tsx Outdated Show resolved Hide resolved
.../vkui/src/components/ImageBase/ImageBasePositionedComponent/ImageBasePositionedComponent.tsx Outdated Show resolved Hide resolved
mendrew
mendrew reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Шикарно 🔥

.../vkui/src/components/ImageBase/ImageBasePositionedComponent/ImageBasePositionedComponent.tsx Outdated Show resolved Hide resolved
.../vkui/src/components/ImageBase/ImageBasePositionedComponent/ImageBasePositionedComponent.tsx Outdated Show resolved Hide resolved
mendrew
mendrew previously approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Jul 30, 2024
@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Aug 7, 2024
@vkcom-publisher vkcom-publisher removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Aug 8, 2024
@vkcom-publisher vkcom-publisher removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Oct 14, 2024
@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Oct 21, 2024
@vkcom-publisher vkcom-publisher removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Oct 22, 2024
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Oct 29, 2024
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Nov 7, 2024
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Nov 15, 2024
@SevereCloud SevereCloud requested a review from mendrew November 21, 2024 08:34
andrey-medvedev-vk
andrey-medvedev-vk previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Шикарная работа 👏

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Dec 3, 2024
@EldarMuhamethanov EldarMuhamethanov removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Dec 4, 2024
inomdzhon
inomdzhon reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

сорри, пропустил последний моментик((

packages/vkui/src/components/ImageBase/ImageBaseFloatElement/ImageBaseFloatElement.module.css Outdated Show resolved Hide resolved
inomdzhon
inomdzhon approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 👍 👏

   🚀

🔥🔥🔥 🔥

andrey-medvedev-vk
andrey-medvedev-vk approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@EldarMuhamethanov EldarMuhamethanov merged commit 2789dd1 into master Dec 11, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/6924/image-overlay-components branch December 11, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

@egorprnn egorprnn Awaiting requested review from egorprnn

@mendrew mendrew Awaiting requested review from mendrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@EldarMuhamethanov @mendrew @inomdzhon @egorprnn @andrey-medvedev-vk @vkcom-publisher