-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove FormItemTopLabel multiline prop #7578
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit b5ac17e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7578 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 384 384
Lines 11345 11346 +1
Branches 3720 3721 +1
=======================================
+ Hits 10802 10803 +1
Misses 543 543
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Классно, что в тесты добавил комментарии, стало гораздо легче! 💯
Маленький вопорс, возможно, про лишний код.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
✅ v7.0.0-beta.0 🎉 |
✅ v7.0.0 🎉 |
Описание
Сейчас в компонент
FormItemTopLabel
можно прокинуть пропmultiline
. А также данное значение можно получить из контекстаFormItemContext
из поляtopMultiline
. Поэтому нужно выпилить пропmultiline
и всегда брать значение из контекста.Изменения
multiline
изFormItemTopLabel
Release notes
BREAKING CHANGE
FormItem.TopLabel
параметрmultiline
был удален, теперь он всегда берется из параметраtopMultiline
у компонентFormItem