fix(CellButton): decrease space between icon and text #7658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We compensate it with negative margin to keep right distance
andrey-medvedev-vk
added
v6
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 4eadae4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7658 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 383 383
Lines 11347 11347
Branches 3726 3726
=======================================
Hits 10801 10801
Misses 546 546
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BlackySoul
approved these changes
Sep 25, 2024
andrey-medvedev-vk
deleted the
mendrew/fix/CellButton/center-mode-with-icon-in-before
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 25, 2024
исправлен слишком большой отступ между иконкой в before и текстом в режиме centered.
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 25, 2024
исправлен слишком большой отступ между иконкой в before и текстом в режиме centered.
| ✅ v6.7.2 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Расстояние между иконкой, помещённой в
beforeи текстом в режимеcenteredбольше чем раньше.Изменения
Уменьшаем расстояние за счёт отрицательного марджина на размер паддинга по умолчанию, заданного в
before. Используем css переменную.Иначе сделать никак, потому что паддинг задаётся в
SimpleCell__beforeи он сразу больше того значения, которое мы хотим задать в режимеcentered.12pxпротив8px.Release notes
Исправления
beforeи текстом в режимеcentered.