feat(SegmentedControl): support using SegmentedControl as tabs #7960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
e2e tests
|
vkcom-publisher
added
the
pr-needs-work
EldarMuhamethanov
removed
the
pr-needs-work
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
👀 Docs deployed
Commit a6e884e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7960 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 396 397 +1
Lines 11235 11271 +36
Branches 3720 3730 +10
=======================================
+ Hits 10731 10766 +35
- Misses 504 505 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
reviewed
Dec 10, 2024
packages/vkui/src/components/SegmentedControl/SegmentedControlOption/SegmentedControlOption.tsx
Outdated
Show resolved
Hide resolved
packages/vkui/src/components/SegmentedControl/SegmentedControl.tsx
Outdated
Show resolved
Hide resolved
packages/vkui/src/components/SegmentedControl/SegmentedControl.tsx
Outdated
Show resolved
Hide resolved
inomdzhon
approved these changes
Dec 11, 2024
andrey-medvedev-vk
approved these changes
Dec 11, 2024
EldarMuhamethanov
deleted the
e.muhamethanov/7952/segmented-control-a11y
branch
BlackySoul
pushed a commit
that referenced
this pull request
Dec 16, 2024
* feat(SegmentedControl): support using SegmentedControl as tabs * test(SegmentedControl): add tests * fix(SegmentedControl): refactor logic * fix(SegmentedControl): fix before renderning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавлена поддержка WAI-ARIA для компонента
SegmentedControlпри использовании в качестве табов. Реализована навигация с помощью клавиатуры и корректная семантическая разметка для улучшения доступности.Изменения
useTabsNavigationизTabsдля обработки клавиатурной навигации и переиcпользовал вSegmentedControlSegmentedControlдобавлена поддержка ролиtablistRelease notes
Улучшения
role="tablist"