fix(PanelHeader): hide separator with transparent PanelHeader #8006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests
|
👀 Docs deployed
Commit 7cb96e4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8006 +/- ##
==========================================
- Coverage 95.47% 95.46% -0.01%
==========================================
Files 380 380
Lines 11325 11324 -1
Branches 3777 3777
==========================================
- Hits 10812 10811 -1
Misses 513 513
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrey-medvedev-vk
approved these changes
Dec 3, 2024
SevereCloud
approved these changes
Dec 10, 2024
EldarMuhamethanov
deleted the
e.muhamethanov/7895/fix-panel-header-separator
branch
|
патч в |
EldarMuhamethanov
added a commit
that referenced
this pull request
Dec 16, 2024
* fix(PanelHeader): hide separator with transparent PanelHeader * fix(PanelHeader): run prettier (cherry picked from commit c22b02b)
EldarMuhamethanov
added a commit
that referenced
this pull request
Dec 16, 2024
* fix(ContentCard): fix height of ContentCard content (#7945) (cherry picked from commit 09a9c40) * fix(PanelHeader): hide separator with transparent PanelHeader (#8006) * fix(PanelHeader): hide separator with transparent PanelHeader * fix(PanelHeader): run prettier (cherry picked from commit c22b02b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Сейчас есть проблема, что при отключенном разделителе(
delimiter="none"), приfloat={true}и при прозрачной панели(transparent={true}) все равно отображается разделитель, который наезжает на контент и портит вид.Изменения
Добавил проверку на отсутствие селектора
.trnspпри отрисовке разделителя.Release notes
Исправления
PanelHeaderиdelimiter="none"