fix(FormField): fix nesting of selectors #8007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8007 +/- ##
==========================================
- Coverage 95.50% 95.49% -0.01%
==========================================
Files 394 393 -1
Lines 11205 11199 -6
Branches 3712 3711 -1
==========================================
- Hits 10701 10695 -6
Misses 504 504
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👀 Docs deployed
Commit bb06c86 |
SevereCloud
previously approved these changes
Nov 27, 2024
# Conflicts: # packages/vkui/src/components/FormField/FormField.module.css
EldarMuhamethanov
dismissed stale reviews from andrey-medvedev-vk and SevereCloud
via
bb06c86
andrey-medvedev-vk
approved these changes
Dec 3, 2024
EldarMuhamethanov
deleted the
e.muhamethanov/fix-date-input-pickers-mode
branch
| ✅ v7.1.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Сейчас пикеры месяца и года в календаре выглядят по-разному в
CalendarиDateInput, при этом у них одинаковый тип:Компонент Calendar:
Компонент DateInput:
Правильно в
Calendar, а вот вDateInputпочему-то считает, что modeFormField="default"а не"plain"Поисследовав, оказалось, что проблема появилась после pr #6800. После него поповер с календарем стал рендериться не в портале, а прямо внутри компонента.
Из-за этого возникла следующая ситуация:
Поскольку
DateInput- это тожеFormFieldсmode="default", а поповер стал рендериться внутри этогоFormField(пикеры соответственно тоже) стал срабатывать следующие селекторы(не только они, но остальные по тому же принципу)Решением является добавление комбинатора ">", для того, чтобы данные стили срабатывали только для непосредственных потомков
Изменения
Добавил комбинаторы ">" в несколько мест, связанных с отображением border, для того, чтобы данные стили срабатывали только для непосредственных потомков
Release notes
Исправления