-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(HorizontalScroll/CardScroll): Rename testId props to prevButton/nextButton #8062
Conversation
To make them more consistent
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests
|
👀 Docs deployed
Commit ef2d07e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8062 +/- ##
==========================================
+ Coverage 95.54% 95.57% +0.02%
==========================================
Files 399 399
Lines 11365 11431 +66
Branches 3753 3778 +25
==========================================
+ Hits 10859 10925 +66
Misses 506 506
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Спасибо 🙏 |
…nextButton (#8062) To make them more consistent
✅ v7.1.0 🎉 |
Описание
В комментарии @inomdzhon обратил внимание на то, что мы придерживаемся других имен для кнопок переключения вперёд/назад.
Например, в Calendar или Pagination мы используем
prevButton
/nextButton
а не названия из логических свойств.VKUI/packages/vkui/src/components/Calendar/Calendar.tsx
Lines 140 to 141 in ef2d07e
VKUI/packages/vkui/src/components/Pagination/Pagination.tsx
Lines 128 to 129 in ef2d07e
Release notes