Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HorizontalScroll/CardScroll): Rename testId props to prevButton/nextButton #8062

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

andrey-medvedev-vk
Copy link
Contributor


Описание

В комментарии @inomdzhon обратил внимание на то, что мы придерживаемся других имен для кнопок переключения вперёд/назад.

в случае HorizontalScroll и CardScroll по семантике не стоило ли назвать prevArrowTestId и nextArrowTestId?

UPD
или prevButtonTestId и nextButtonTestId

Например, в Calendar или Pagination мы используем prevButton/nextButton а не названия из логических свойств.

prevMonthButtonTestId,
nextMonthButtonTestId,

prevButtonTestId,
nextButtonTestId,

Release notes

Copy link
Contributor

github-actions bot commented Dec 11, 2024

size-limit report 📦

Path Size
JS 391.37 KB (+0.01% 🔺)
JS (gzip) 118.33 KB (+0.01% 🔺)
JS (brotli) 97.46 KB (+0.04% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 340.96 KB (0%)
CSS (gzip) 42.23 KB (0%)
CSS (brotli) 33.63 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

github-actions bot commented Dec 11, 2024

👀 Docs deployed

Commit ef2d07e

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (07017a6) to head (ef2d07e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8062      +/-   ##
==========================================
+ Coverage   95.54%   95.57%   +0.02%     
==========================================
  Files         399      399              
  Lines       11365    11431      +66     
  Branches     3753     3778      +25     
==========================================
+ Hits        10859    10925      +66     
  Misses        506      506              
Flag Coverage Δ
unittests 95.57% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrey-medvedev-vk andrey-medvedev-vk marked this pull request as ready for review December 11, 2024 12:09
@andrey-medvedev-vk andrey-medvedev-vk requested a review from a team as a code owner December 11, 2024 12:09
@andrey-medvedev-vk andrey-medvedev-vk merged commit 2d46991 into master Dec 11, 2024
53 checks passed
@andrey-medvedev-vk andrey-medvedev-vk deleted the mendrew/rename-testid-props branch December 11, 2024 13:00
@inomdzhon
Copy link
Contributor

Спасибо 🙏

BlackySoul pushed a commit that referenced this pull request Dec 16, 2024
@vkcom-publisher
Copy link
Contributor

v7.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants