fix(UsersStack): make counter width adaptive #8066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
EldarMuhamethanov
removed
the
patch
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests
|
👀 Docs deployed
Commit caa57a4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8066 +/- ##
==========================================
+ Coverage 95.54% 95.58% +0.04%
==========================================
Files 398 393 -5
Lines 11306 11205 -101
Branches 3734 3690 -44
==========================================
- Hits 10802 10710 -92
+ Misses 504 495 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrey-medvedev-vk
approved these changes
Dec 12, 2024
EldarMuhamethanov
deleted the
e.muhamethanov/7573/users-stack-counter-adaptive-width
branch
BlackySoul
pushed a commit
that referenced
this pull request
Dec 16, 2024
* fix(UsersStack): make counter width adaptive * fix: add screenshots * test: update screenshots * fix: remove unused selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Сейчас, в счетчике в компоненте
UsersStackпри двузначном числе, числа прилипают к краям при размере компонента'm'. Нужно сделать так, чтобы ширина счетчика увеличивалась адаптивно содержимомуИзменения
UsersStack, так чтобы ширина увеличивалась в случае, если текст не помещалсяДля дизайн ревью
Чтобы посмотреть новое поведение можно зайти в сторибук, в компонента
UsersStack, и поменять свойствоcountна двузначное числоRelease notes
Исправления