-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Header, SimpleCell): fix icons position with multiline #8144
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit 1461164 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8144 +/- ##
==========================================
- Coverage 95.53% 95.51% -0.02%
==========================================
Files 398 398
Lines 11379 11354 -25
Branches 3757 3742 -15
==========================================
- Hits 10871 10845 -26
- Misses 508 509 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Возможно, нужно немного изменить скриншоты? Сейчас |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Как будто теперь в скриншотах не хватает примера заявленного в описании:
Нужно сделать так, чтобы иконки после текстов в компонентах Header и SimpleCell при multiline=true не прижимались к правому краю
В любом случае, нужен ведь ещё аппрув дизайна, да?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
* fix(Header, SimpleCell): fix icons position with multiline * test(SimpleCell, Header): add screenshots with long text
Описание
Нужно сделать так, чтобы иконки после текстов в компонентах
Header
иSimpleCell
приmultiline=true
не прижимались к правому краюRelease notes
Исправления
multiline=true
multiline=true