Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Header, SimpleCell): fix icons position with multiline #8144

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Jan 13, 2025


  • Дизайн ревью
  • Release notes

Описание

Нужно сделать так, чтобы иконки после текстов в компонентах Header и SimpleCell при multiline=true не прижимались к правому краю

Release notes

Исправления

  • SimpleCell: Поправлено отображение иконок после текста при multiline=true
  • Header: Поправлено отображение иконок после текста при multiline=true

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner January 13, 2025 12:40
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jan 13, 2025
Copy link

codesandbox-ci bot commented Jan 13, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

size-limit report 📦

Path Size
JS 391.87 KB (0%)
JS (gzip) 118.89 KB (0%)
JS (brotli) 97.79 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 342.8 KB (-0.04% 🔽)
CSS (gzip) 42.47 KB (-0.04% 🔽)
CSS (brotli) 33.83 KB (-0.05% 🔽)

Copy link
Contributor

github-actions bot commented Jan 13, 2025

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jan 13, 2025

👀 Docs deployed

Commit 1461164

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (6b6165d) to head (1461164).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8144      +/-   ##
==========================================
- Coverage   95.53%   95.51%   -0.02%     
==========================================
  Files         398      398              
  Lines       11379    11354      -25     
  Branches     3757     3742      -15     
==========================================
- Hits        10871    10845      -26     
- Misses        508      509       +1     
Flag Coverage Δ
unittests 95.51% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul
Copy link
Contributor

Возможно, нужно немного изменить скриншоты? Сейчас multiline={false} не отличается от multiline={true}, мейби хотя бы в 2 строки пример сделать?

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Как будто теперь в скриншотах не хватает примера заявленного в описании:

Нужно сделать так, чтобы иконки после текстов в компонентах Header и SimpleCell при multiline=true не прижимались к правому краю

В любом случае, нужен ведь ещё аппрув дизайна, да?

@EldarMuhamethanov EldarMuhamethanov requested a review from a team January 14, 2025 12:06
Copy link
Contributor

@qurle qurle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@EldarMuhamethanov EldarMuhamethanov merged commit ae930a3 into master Jan 15, 2025
28 of 29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8102/multiline-fix branch January 15, 2025 09:18
vkcom-publisher pushed a commit that referenced this pull request Jan 15, 2025
* fix(Header, SimpleCell): fix icons position with multiline

* test(SimpleCell, Header): add screenshots with long text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SimpleCell. badgeAfterTitle уходит вправо, если указан пропс multiline
5 participants