Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

マルチエンジン:SET_ENGINE_SETTINGを追加 #1152

Merged
merged 3 commits into from
Jan 28, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

エンジン毎の設定をSET_ENGINE_SETTINGに移動します。

関連 Issue

スクリーンショット・動画など

(なし)

その他

オブジェクトのクローン周りでエラーを吐かれていたのも修正します。

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner January 28, 2023 14:33
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team January 28, 2023 14:33
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

動作確認もしてみました、問題なさそうでした!!

@Hiroshiba
Copy link
Member

たぶん大丈夫だと思うのでマージします!!

@Hiroshiba Hiroshiba merged commit 2f99b7d into VOICEVOX:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants