Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vvppアイコン・vvprojアイコン追加 #1155

Merged
merged 1 commit into from
Jan 30, 2023
Merged

vvppアイコン・vvprojアイコン追加 #1155

merged 1 commit into from
Jan 30, 2023

Conversation

Hiroshiba
Copy link
Member

内容

vvppアイコン・vvprojアイコン追加します。

関連 Issue

スクリーンショット・動画など

その他

おひのっとさんから頂きました！
https://twitter.com/ohinot/status/1619618029075329025

@Hiroshiba Hiroshiba requested a review from a team as a code owner January 29, 2023 16:55
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team January 29, 2023 16:55
@Hiroshiba
Copy link
Member Author

image
実際にビルドしてみてアイコンが変わるのを検証済みです！

y-chan
y-chan approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@sevenc-nanashi sevenc-nanashi mentioned this pull request Jan 30, 2023
Closed
@sevenc-nanashi
Copy link
Member

LGTM！
image

image

@Hiroshiba
Copy link
Member Author

スクショありがとうございます！
見分けもしっかりつくし、ボイボ感もあってわかりやすそうですね！！

マージします！

@Hiroshiba Hiroshiba merged commit b32b979 into VOICEVOX:main Jan 30, 2023
@Hiroshiba Hiroshiba deleted the VVPPアイコン・vvprojアイコン追加 branch January 30, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevenc-nanashi sevenc-nanashi sevenc-nanashi approved these changes

@y-chan y-chan y-chan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hiroshiba @sevenc-nanashi @y-chan