Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script setup: デフォルトスタイルのダイアログを移行 #1175

Merged
merged 2 commits into from
Feb 5, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

タイトル通り。

関連 Issue

ref: #1065

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner February 4, 2023 07:44
@sevenc-nanashi sevenc-nanashi requested review from y-chan and removed request for a team February 4, 2023 07:44
@sevenc-nanashi sevenc-nanashi changed the title Migrate: デフォルトスタイルのダイアログを移行 script setup: デフォルトスタイルのダイアログを移行 Feb 4, 2023
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

いくつか未利用変数としてワーニングとなっていました。ついでに消しちゃっても良いかも?(どちらでも良さそう)
そこ以外は全く問題なさそうに思いました!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

マージします!じゃんじゃん行っちゃいましょう!!

@Hiroshiba Hiroshiba merged commit 668a182 into VOICEVOX:main Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants