Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script setup：ヘルプダイアログをscript setup化 #1180

Merged
merged 2 commits into from
Feb 5, 2023
Merged

script setup：ヘルプダイアログをscript setup化 #1180

merged 2 commits into from
Feb 5, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

タイトル通り。

関連 Issue

スクリーンショット・動画など

（なし）

その他

（なし）

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner February 5, 2023 04:34
@sevenc-nanashi sevenc-nanashi requested review from y-chan and removed request for a team February 5, 2023 04:34
Hiroshiba
Hiroshiba approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

またついでに未使用エラー出てる変数などを消していただけると…！
（たぶんほかのPRでも無限に出てしまうので。。。）

@Hiroshiba Hiroshiba merged commit 886243a into VOICEVOX:main Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@y-chan y-chan Awaiting requested review from y-chan y-chan was automatically assigned from VOICEVOX/maintainer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vue3の<script setup>を使うようにする
2 participants
@sevenc-nanashi @Hiroshiba