Refactor: デフォルトファイル名取得関数2つをgetterへ移動 #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
requested changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
デフォルトのプロジェクト名と音声ファイル名を返す関数をstore.getterに移動しました。
ユーザー視点での変更はありません。
関連 Issue
ref #1475
上記の一環です。
スクリーンショット・動画など
その他
プロジェクト名取得(
DEFAULT_PROJECT_FILE_BASE_NAME)は、名前的にはproject.tsが妥当なんですが、audio.tsの繋げて書き出し2種の時にも参照されているのと、内部処理的にもaudioItemを参照しているのでどちらに置くべきか微妙なところかもです。とりあえずaudio.tsのほうに置いてみました。