Refactor: 再生中のアクセント句の見た目を強調する処理を改善 #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Aug 27, 2023
|
眺めていたら処理の重さが未知数の |
y-chan
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
具体的には以下の点を変更しました。
setIntervalをrequestAnimationFrameに変更currentTime !== undefineの判定をforループの外に出すforループをfindIndexへ変更activePoint.value変更時)のみscrollToActivePointが実行されるように変更ユーザー視点での変更はありません。
関連 Issue
エラー分岐の理由に関係
その他
Window.requestAnimationFrame() - Web API | MDN
次フレームの直前に実行される処理を指定できるメソッドです。