-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 停止ボタンを連続再生中と通常再生中で共用にする #1534
Merged
Hiroshiba
merged 5 commits into
VOICEVOX:main
from
thiramisu:show-stop-button-while-playing-continuously
Sep 5, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0db2486
feat: 連続再生中も再生/停止ボタンを表示
thiramisu 04f4464
feat: ツールバーの停止ボタンを通常再生中にも使えるようにする
thiramisu 85643ac
refactor(stop): `名前を`stopContinuously`から変更
thiramisu 132848e
review: 再生中かの条件文を`IS_PLAYING`にまとめる
thiramisu a3ad51d
IS_PLAYING→NOW_PLAYING
Hiroshiba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(すみません、レビューしたタイミングでちょうどgithubに障害が起きてレビューが反映できていませんでした・・・。)
ここは
IS_PLAYING
よりNOW_PLAYING
のがあってそうに思いました!isなんとか
は動詞なのでメソッド名や関数名になることが多そうです。実際この上にある
IS_ACTIVE
は引数を受け取るメソッドライクになっていそうです。