複数選択：キャラクターを変更できるように #1546
Merged
複数選択：キャラクターを変更できるように #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Sep 13, 2023
src/components/AudioCell.vue
Outdated
| const isInitializingSpeaker = computed( | ||
| () => store.state.audioKeyInitializingSpeaker === props.audioKey | ||
| const isInitializingSpeaker = computed(() => | ||
| store.state.audioKeysInitializingSpeaker.includes(props.audioKey) |
There was a problem hiding this comment.
これ2回出てきてるので、AudioKeyを引数にしたGETTER関数isInitializingSpeakerにしてあげてもいいかも。
まあシンプルなのでそのままでもいいかも。
There was a problem hiding this comment.
シンプルなのでそのままで良いと思います
|
レビューを反映しました。 |
|
レビューを反映しました。 |
Hiroshiba
reviewed
Sep 19, 2023
|
修正しました。 |
Hiroshiba
approved these changes
Sep 19, 2023
|
問題なさそうなのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
タイトル通り。
関連 Issue
スクリーンショット・動画など
VOICEVOX.-.Ver.999.999.999.Mozilla.Firefox.2023-09-18.11-32-25.mp4
その他
（なし）