Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: AudioDetail.vueのHTML部分の記述を整理しコメントを追加 #1559

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

thiramisu
Copy link
Contributor

内容

#1554 のために<context-menu>をどこに書くかを検討したかったのですが、ぱっと見整理されておらず迷子になりました。
一箇所条件を整理してコメントを書くだけで見やすさが改善されるように思えたので、実施してみました。
ユーザー視点での変更はありません。

関連 Issue

その他

@thiramisu thiramisu requested a review from a team as a code owner September 16, 2023 22:04
@thiramisu thiramisu requested review from y-chan and removed request for a team September 16, 2023 22:04
@thiramisu thiramisu changed the title refactor: AudioDetail.vueの記述を整理しコメントを追加 refactor: AudioDetail.vueのHTML部分の記述を整理しコメントを追加 Sep 16, 2023
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
コメント助かります...!
一部変更がありますが、特に問題なさそうでした。
(というかなんでいままでtemplateの中になかったんだろう...)

@Hiroshiba Hiroshiba merged commit 1e6ce71 into VOICEVOX:main Sep 17, 2023
@thiramisu thiramisu deleted the add-comment-to-audio-detail branch September 17, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants