refactor: store/audio.ts
内の不要になっていたgetterを削除
#1580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
store/audio.ts
内の不要になっていたgetter、HAVE_AUDIO_QUERY
とIS_ACTIVE
を削除します。ユーザー視点での変更はありません。
IS_ACTIVE
は無くても一行で書けるので今後を考えても消して問題なさそうです。HAVE_AUDIO_QUERY
も一行で書けますし、大抵はquery.hogeって感じで続くので、一時的にconst query = state.audioItems[audioKey].query;
みたいに書くのがさほど不自然ではなく、消しても問題ないかなと思いました。ただ
query .=
で正規表現検索したところ、無い場合にエラーという処理が多かったので、もしかしたらみたいなのがあってもいいのかもです。
関連 Issue
store/audio.ts
周りのリファクタリング #1475上記の一環です。
その他