Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-s] ズーム周りの調整 #1640

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

sigprogramming
Copy link
Contributor

内容

スライダーを操作したときは画面の中央を基準にズーム、
Ctrlキーを押しながらホイールを回したときはマウスカーソル位置を基準にズーム(水平方向)するようにします。
また、SequencerKeysの幅とSequencerRulerの高さをResizeObserverで取得するようにします。

関連 Issue

VOICEVOX/voicevox_project#15

スクリーンショット・動画など

2023-11-05.234522.mp4

その他

@sigprogramming sigprogramming requested a review from a team as a code owner November 5, 2023 14:57
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!

ResizeObserver

なるほどです!
heightやwidthはsvgに必要で、であれば外から与えるよりコンポーネント内で完結させるこの形が良いように感じました!!

src/components/Sing/SequencerKeys.vue Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@Hiroshiba Hiroshiba merged commit cb468f0 into VOICEVOX:project-s Nov 6, 2023
@sigprogramming sigprogramming deleted the adjustment_zoom branch December 1, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants